From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id GH7RHzC/M2ZL1wAA62LTzQ:P1 (envelope-from ) for ; Thu, 02 May 2024 18:28:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id GH7RHzC/M2ZL1wAA62LTzQ (envelope-from ) for ; Thu, 02 May 2024 18:28:32 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Zx8w9Q3a; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714667312; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ZcYBzrr/t29ZpOGICqOiK/5/hdHNdCB9fNzahTwA3TA=; b=StGszTbQCDT3anw3PSVHVDlgtLhqiInGYtT/seutaAzgShg5ZSZ8aHNsJEJMqiGLyIuch+ w79I5wvthbl8XpAkmw0CkGbquwTInSWFIdx8GJtEgMIVK4TSOOINRkJRH4u1O9GdkcifED tTvFe/xm4ju7tN+ovWse7IfwdkRlLYXV7ZJSJVXSxjM2JuyOh0yqwcv9I2fOExdq69DZ0C bypNeVui+wuWLPazsuyvJzup//hCwMW2aS89mNDHIxWQVE0NCguRQl//Shn6pSnNF+FA/a qBY9ss0dY57z8Qso1kVczu7FfsNRg90hRuOBpNNrGIWCmG1WXsyHLhtHIb+JRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714667312; a=rsa-sha256; cv=none; b=jd7hFngfLteFjxj8/zCh8xa1qWWqnta69ha5Ks1aIdFquWuvwbBXheN2OvmZAmAhjjKNzQ gJXsu4o5z4J0Svf+jqPZAJio0YY+mvDqOK3T3JibkL1QSuqhB8LCqKVDbhOrVmRPRC5p4j 5xy4Fuqrni0dJifFkBtdj3jKM44VAdjWwaIfqCsgiDMPbin4rpq/liZyt2PuxrDuWkqBBW 7KefuMKt+7JjwuDy90kdJDB0oqfS5C1no+CEZMww+LKp8pJW3NAk5R72gii4hYRfN4pRx3 YUHaPLKOl21xB+HxnyNi8KEXXVI2FXC19h3OybopdJrr+8/ni83TtdkNHPy5ww== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Zx8w9Q3a; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FCBB3D163 for ; Thu, 02 May 2024 18:28:32 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2ZHm-0004x5-9x; Thu, 02 May 2024 12:27:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2ZHl-0004uw-1w for emacs-orgmode@gnu.org; Thu, 02 May 2024 12:27:53 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2ZHZ-0000U0-P4 for emacs-orgmode@gnu.org; Thu, 02 May 2024 12:27:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7E9C7240105 for ; Thu, 2 May 2024 18:27:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714667259; bh=ZcYBzrr/t29ZpOGICqOiK/5/hdHNdCB9fNzahTwA3TA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=Zx8w9Q3alSzqIH4ZR2tb/SFg8in/iB1AVQm229SloVJUH1RgpTU8znWNyiioIkgeu TlMKKnpFQIL+bbFJh4ORyXQhgMbgHp9F+3gG8VF8kbqmkBd0vIHWrQW0cUk7OYcLgs lMy6Lhy3ieWv6s5H3StOKshok1ilbGTDq+pd+Y7QXoGFcnY3sHtqA7EV9primaBJ09 CTJ2/rgulmEv9AoNSVlHwlYYq9AeV4lwUsu9glQPkIAE8CG8J8HnTFbwpzzS3XMvBH q/cQ1+YI6clWpImJMlCgmENi9gKwLZoBcYFxEVNk7WUlEonECbYGuDi8jaQZ053hhw 9+xqeJkp1l7DA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VVfVL5GPcz9rxB; Thu, 2 May 2024 18:27:38 +0200 (CEST) From: Ihor Radchenko To: Matt Huszagh Cc: Timothy , Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix regex for determining image width from attribute In-Reply-To: <871r2ucuhz.fsf@gmail.com> References: <87czmtuy0p.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> <87v90jph1w.fsf@gmail.com> <871r37l96a.fsf@gmail.com> <87k0gzpb5s.fsf@gmail.com> <87h7c2pb6w.fsf@gmail.com> <87ee75pmsn.fsf@gmail.com> <87czmjajyx.fsf@gmail.com> <87k0grk0ge.fsf@gmail.com> <87ee6x3t39.fsf@gmail.com> <87zgpkq5a5.fsf@gmail.com> <871r2ucuhz.fsf@gmail.com> Date: Thu, 02 May 2024 16:28:46 +0000 Message-ID: <87cyq49o01.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.60 X-Spam-Score: -6.60 X-Migadu-Queue-Id: 2FCBB3D163 X-Migadu-Scanner: mx11.migadu.com X-TUID: u0CL1963OXPM Matt Huszagh writes: >> Thanks for continuing with this. Moving forward, I think it would be bes= t to: >> =E2=81=83 Make a patch just for prioritising `#+attr_org' >> =E2=81=83 Make a patch just improving the regex (before or after the `#+= attr_org' patch) > ... >> Lastly, a comment on your documentation patch from earlier. I like the c= hanges >> to `org-image-actual-width', however I think you=E2=80=99ve been over-ea= ger with scrapping >> the current docstring for `org-display-inline-image--width'. Since the b= ehaviour >> is implemented there, I think it should at a minimum be documented there. >> The docstring for a function referring to a variable=E2=80=99s documenta= tion for how it=E2=80=99s >> handled by the function seems a bit weird. I have used parts of Matt's patches + the new org-element-ast API to implement all the discussed (and agreed upon) changes: 1. #+attr_org is prioritised 2. Docstrings are updated Handled, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Dfede1c990 --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at