From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id uM9WCCj7QWfxgAAA62LTzQ:P1 (envelope-from ) for ; Sat, 23 Nov 2024 15:56:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id uM9WCCj7QWfxgAAA62LTzQ (envelope-from ) for ; Sat, 23 Nov 2024 16:56:24 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MkM0OrW5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732377383; a=rsa-sha256; cv=none; b=AntUhXxwQToOMLouI5Acx5JkTWMPBl1NAZFhoFl5JtoseOPlrDe+4r/rcPYWknBYd/za4i BlsP6weon7RtI5rH3ySaqlsZtH3IDzhvVtE9XhM4bhLpbtPpx5VGiNRVKVLKT0NFsrJt7l N/vlyAy93QIErJQtqyiTzteXg+Zf4rkg8Xshw9Yeg9ULl+f+qzQrEIO3E6XFp6SQoxqL9k cjSerIE/Y+P6tqfKyFvU6fv06jJHHmcqqgk/l2AHRoKnM4xWC9hOSE6Uueq5OGrN5wJwBL 1B2J6P1Y6jANQi/FJZa0ggRLIOlrnbsDMo7Hj/1ZRInvbzIhc8iPuG0TZ9YZHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MkM0OrW5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732377383; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jwlWysSQdIMfNhfwMa3TmucqAyzSJon1EFm/ajcGooM=; b=HrFZ4i0eaYARiTFKK95lO74+7YrqswHmA3i5Mo7kQuCrw5vbTeJrx8RXzCxDPv73ZVrM+a 78fdnARvLSKUuLNifMTPQxAyDyIIi3oIqyduoNF1K3lob5/OOfZDNJyYEyB3H7949EsiQ7 RMDCUkIlPQ4+1muuMOL8pYUKiCy7bGo3hMWvRtbKshlAIuv2ODv4YdHK/q+FGKRLtDjvp0 FrMKmZFw9HKdQvOzMLc4wv7syFpH3LTWOZyvVxWsE6AECBJlujPu76x/lZWNJoBSR9TLCC u8jos6r1RZEneo8ZfnmBpo3Ruz/bMu0qbBjebpBVmg3pgWLuZlBNFSKbWginnA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99C261835C for ; Sat, 23 Nov 2024 16:56:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEsU0-0002K1-Td; Sat, 23 Nov 2024 10:55:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEsTy-0002Jh-6w for emacs-orgmode@gnu.org; Sat, 23 Nov 2024 10:55:38 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEsTv-0002VE-SJ for emacs-orgmode@gnu.org; Sat, 23 Nov 2024 10:55:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 26C05240101 for ; Sat, 23 Nov 2024 16:55:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732377332; bh=FWl2XCM0VKuRtk/Eir/KyWlpIkKk0F9lbtnoCrJHem4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=MkM0OrW5HYx6+zv8WtUYzTeEmOsgMEkrMBQ6+c2sY0WDF+zImOC619hpxu2yfo/KC eBHcXxIfH3Di1sTlDbiInzqFn36IN4Lh+FZX1Hnalpgce2EhnRBrEWQoWMPqPDZRAz 6u/WGWOpS0bTGgAqxUYbzBKVQYLqqsiNOO2JbtZJxg0BAOLkuk3hI1XpOXaAgkpTY4 7Du5hauN1RKaHQUz39NO/6lCf74m6CtJjcqJcVNYaO/xztzJVSJ6Fts+DcuOpPZSbE p7f90gRlfRPlhNK41bCBs+Sh00aADty08miAcrGpsUZjxPn3/O68SvhsbsdPogqUTJ HDaF8Mqial9Qw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Xwc4g3YMDz6tw1; Sat, 23 Nov 2024 16:55:31 +0100 (CET) From: Ihor Radchenko To: John C Cc: emacs-orgmode@gnu.org Subject: Re: ob-octave: improve MATLAB support In-Reply-To: References: <87pln4g3b2.fsf@localhost> Date: Sat, 23 Nov 2024 15:57:06 +0000 Message-ID: <87cyim9c4t.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.00 X-Spam-Score: -5.00 X-Migadu-Queue-Id: 99C261835C X-Migadu-Scanner: mx12.migadu.com X-TUID: MEzfomSJccXf John C writes: > Thanks for the feedback. I incorporated some of your suggestions for > org-mode. I'll add the examples to https://git.sr.ht/~bzg/worg once > the changes become part of org-mode. Thanks for the update! > Regarding (defvar org-babel-default-header-args:matlab '((:session . > "*MATLAB*")), this was done on purpose. We've been using this setting > for a while. Without it, org matlab evaluation is not good. I added a > comment as to why it's there. I can see the usefulness of using session by default for matlab, but it is still going to be a breaking change. As a minimum, we should announce it in the NEWS. You may (1) split your news entry into "fix" part and ":results handling" ; (2) add notice that matlab blocks will use session by default > I looked into the use of REMOVE-ECHO which ob-octave.el already sets > to t and don't believe this will help us. I think low-level comit > requires the input which is captured by org. May you please elaborate what exactly is not working when using REMOVE-ECHO? Note that you normally need to pass the body alongside with REMOVE-ECHO argument and `org-babel-comint-with-output' should remove everything up to FULL-BODY before returning the output. The problem you are trying to solve _should_ be solved by `org-babel-comit-with-output'. If it is not, it is a bug that we should fix. > Any guidance on adding a test? To test properly we'll need MATLAB and > https://github.com/mathworks/Emacs-MATLAB-Mode. Note, in > https://github.com/mathworks/Emacs-MATLAB-Mode, I have a test for all > this. Currently Emacs-MATLAB-Mode is advising org to get things > working. When org is updated, Emacs-MATLAB-Mode will automatically not > advise org. For tests, you can refer to testing/lisp/test-ob-R.el tests. They also rely upon external package (ESS) and on external R executable. Ideally, we want to reuse tests from testing/lisp/test-ob-octave.el -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at