From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bert Burgemeister Subject: Re: [PATCH] Bugfix: org-agenda-open-link Date: Sat, 19 Mar 2011 13:14:59 +0100 Message-ID: <87bp17488s.fsf@ID-264851.user.dfncis.de> References: <87lj0jf3qj.fsf@ID-264851.user.dfncis.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=51059 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0v45-0000pT-6P for emacs-orgmode@gnu.org; Sat, 19 Mar 2011 08:15:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0v41-0007yI-8N for emacs-orgmode@gnu.org; Sat, 19 Mar 2011 08:15:29 -0400 Received: from lo.gmane.org ([80.91.229.12]:47294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0v40-0007yA-Ry for emacs-orgmode@gnu.org; Sat, 19 Mar 2011 08:15:25 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q0v3y-0002qw-V9 for emacs-orgmode@gnu.org; Sat, 19 Mar 2011 13:15:22 +0100 Received: from port-92-206-208-220.dynamic.qsc.de ([92.206.208.220]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 19 Mar 2011 13:15:22 +0100 Received: from trebbu by port-92-206-208-220.dynamic.qsc.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 19 Mar 2011 13:15:22 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bert Burgemeister writes: > * Org-agenda.el (org-agenda-open-link): C-c C-o didn't open links > inserted via the `%%( )' mechanism, affecting usability of > `%%(org-bbdb-anniversaries). > > TINYCHANGE > --- > > > The bug was apparently introduced in commit > ba1e90893d128d8004e4cb6763af692c5a6cd677. > > -- > Bert > > > > lisp/org-agenda.el | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 4b4dd68..123668c 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -6742,13 +6742,13 @@ at the text of the entry itself." > (+ (point-at-bol) > (or (org-get-at-bol 'prefix-length) 0))))) > (cond > - (buffer > - (with-current-buffer buffer > - (save-excursion > - (save-restriction > - (widen) > - (goto-char marker) > - (org-offer-links-in-entry arg prefix))))) > + ((and buffer > + (with-current-buffer buffer > + (save-excursion > + (save-restriction > + (widen) > + (goto-char marker) > + (org-offer-links-in-entry arg prefix)))))) > ((or (org-in-regexp (concat "\\(" org-bracket-link-regexp "\\)")) > (save-excursion > (beginning-of-line 1) Ok, perhaps I should complement my patch with a bug report. %%(org-bbdb-anniversaries) inserts birthdays into the agenda that contain links to the respective BBDB entry. These links are broken. Here is a demonstration of the bug that doesn't require BBDB. Put the following line into one of your agenda files: %%((lambda () (concat "[[" "http" "://example.com" "]" "]"))) M-x org-agenda-list now includes decent links to http://example.com. C-c C-o on one of them answers "No links". -- Bert