From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: bug with org-mode-hook and text-scale-set
Date: Fri, 20 Apr 2012 15:00:52 +0200
Message-ID: <87bommv9q3.fsf@altern.org>
References: <CALr_ej1jNO4VAmORstci+O+-ZKf4OGpzs5s3q5fbL+47zv9UWQ@mail.gmail.com>
	<87r4wveo3u.wl%dmaus@ictsoc.de>
	<CALr_ej2Ae8_rToEEnxcyVt=aPbR9R_F-Lsi4aMOufA9+dne8BQ@mail.gmail.com>
	<87obrfu1m6.fsf@gnu.org> <874nspt2ep.fsf@fastmail.fm>
	<87vcl4st3c.fsf@fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:52609)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDWE-0005IU-J0
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 09:05:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDW7-0001Nr-Sq
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 09:04:58 -0400
Received: from mail-wi0-f171.google.com ([209.85.212.171]:53251)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDW7-0001IH-KS
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 09:04:51 -0400
Received: by wibhj13 with SMTP id hj13so480040wib.12
	for <emacs-orgmode@gnu.org>; Fri, 20 Apr 2012 06:04:49 -0700 (PDT)
In-Reply-To: <87vcl4st3c.fsf@fastmail.fm> (Matt Lundin's message of "Thu, 12
	Apr 2012 13:28:07 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matt Lundin <mdl@imapmail.org>
Cc: Du Yanning <duyanning@gmail.com>, emacs-orgmode <emacs-orgmode@gnu.org>, David Maus <dmaus@ictsoc.de>

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> Matt Lundin <mdl@imapmail.org> writes:
>
>> Bastien <bzg@gnu.org> writes:
>>
>>> Du Yanning <duyanning@gmail.com> writes:
>>>
>>>> text-mode-hook and c-mode-hook do NOT have this bug.
>>>> and the org-mode-hook of orgmode shipped within emacs 23.3 does NOT
>>>> have this bug.
>>>
>>> This is now fixed, thanks.
>>>
>>> The problem was that Org relied on `face-remapping-alist' to 
>>> remap the 'default face to the 'org-default face.  Relying on 
>>> this mechanism produces the error you reported, because the 
>>> text-scale-set doesn't interact well with remapped faces.
>>>
>>> I'm now relying on `buffer-face-mode' which seems to be a 
>>> cleaner approach.
>>
>> On my machine, this change causes a noticeable lag when typing in
>> org-mode buffers. The cursor hesitates for a bit and then lurches
>> forward. If I turn off buffer-face-mode the lag disappears. I'm still
>> figuring out how to diagnose the problem.
>
> Another question: is it customary for major modes to invoke
> buffer-face-mode? 

Emacs devs said using buffer-face-mode is "obnoxious".  So I
buffer-face-mode is not turned on by default anymore.  org-default is
still the face for buffer-face-mode, though.

-- 
 Bastien