From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: Compilation problem
Date: Tue, 18 Sep 2012 15:22:17 +0200
Message-ID: <87boh331py.fsf@bzg.ath.cx>
References: <m2pq5u2h8h.fsf@top.irisa.fr>
	<5986.1347306768@alphaville.americas.hpqcorp.net>
	<87wr01hc4f.fsf@Rainer.invalid> <87lighr5xf.fsf@altern.org>
	<87pq5thbno.fsf@Rainer.invalid> <87har5r5iv.fsf@altern.org>
	<87wr01sdsu.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:52233)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TDxkv-00070X-MQ
	for emacs-orgmode@gnu.org; Tue, 18 Sep 2012 09:22:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TDxkp-0003OL-QU
	for emacs-orgmode@gnu.org; Tue, 18 Sep 2012 09:22:25 -0400
Received: from mail-we0-f169.google.com ([74.125.82.169]:50088)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1TDxkp-0003O9-Jj
	for emacs-orgmode@gnu.org; Tue, 18 Sep 2012 09:22:19 -0400
Received: by weys10 with SMTP id s10so5004187wey.0
	for <emacs-orgmode@gnu.org>; Tue, 18 Sep 2012 06:22:18 -0700 (PDT)
In-Reply-To: <87wr01sdsu.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11
	Sep 2012 04:09:29 +0530")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jambunathan K <kjambunathan@gmail.com>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org

Hi Jambunathan,

Jambunathan K <kjambunathan@gmail.com> writes:

> Please ask for clarification and politely indicate that a change may
> have to be reverted.  

Sorry that I reverted this one too hastily and without warning.

> Instead of the commit being wrong, is it possible that
> changes were incomplete.  

I understand.

What would be helpful would be some comment in the commit telling 
that the change is part of a bigger change that is not yet committed.

But I think we should try to avoid this: the whole point of using git 
is to commit changes only if they are complete.  A "change" can be a
commit or a set of commits, but let's try to push changes only when
they are complete.

I know this is not always easy, and I'm not lecturing here, I'm just
sharing directions I try to follow myself.

Thanks,

-- 
 Bastien