emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-agenda-write taking very long (probably because of babel)
Date: Thu, 28 Feb 2013 09:56:53 +0100	[thread overview]
Message-ID: <87bob4g6ju.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87y5e9icwc.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 27 Feb 2013 23:56:51 +0100")

Hi Achim,

Achim Gratz <Stromeko@nexgo.de> writes:

> * lisp/ob-core.el (org-babel-execute-src-block): Do not ask for
>   confirmation if the cached result is current.  Since
>   `org-babel-confirm-evaluate´ does additional things besides asking
>   for confirmation, call it first with `org-confirm-babel-evaluate´
>   bound to nil.  This has the effect that it will never ask the user,
>   but will indicate if the block should be evaluated.  If yes,
>   determine whether the cached result block is current (this is
>   deferred until now since `org-babel-process-params´ might trigger
>   expensive operations).  If `cache-current-p´ is t or
>   `org-confirm-babel-evaluate´ is nil, evaluate the source block
>   without asking.  In case the cache is current the evaluation will
>   not actually do anything but return the cached value, so this is
>   safe.  In case `org-confirm-babel-evaluate´ is nil the user would
>   not be asked anyway, so the call of `org-babel-confirm-evaluate´ is
>   not necessary.  Otherwise run `org-babel-confirm-evaluate´ again to
>   ask permission from the user and act depending on the answer.

Sorry to nitpick on this but please keep the Emacs-like change log
small, if not terse.  Additionnal details are more than welcome in
the commit message though.

Thanks!

-- 
 Bastien

  reply	other threads:[~2013-02-28  8:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27 16:58 org-agenda-write taking very long (probably because of babel) Karl Voit
2013-02-27 17:07 ` Karl Voit
2013-02-27 17:25 ` Bastien
2013-02-27 19:03   ` Achim Gratz
2013-02-27 19:19     ` Achim Gratz
2013-02-27 21:11   ` Achim Gratz
2013-02-27 22:31     ` Bastien
2013-02-27 22:56 ` Achim Gratz
2013-02-28  8:56   ` Bastien [this message]
2013-02-28 10:51     ` Achim Gratz
2013-03-02 15:11       ` Bastien
2013-03-08 19:11   ` Karl Voit
2013-03-10 13:00 ` Achim Gratz
2013-04-10 16:41   ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bob4g6ju.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).