From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Jumping from source block to Org block ... Date: Sun, 15 Sep 2013 05:52:35 -0600 Message-ID: <87bo3upahg.fsf@gmail.com> References: <87y56zqubi.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLAsq-0007Cg-RM for emacs-orgmode@gnu.org; Sun, 15 Sep 2013 07:53:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLAsl-0000Xc-VB for emacs-orgmode@gnu.org; Sun, 15 Sep 2013 07:52:56 -0400 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:57858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLAsl-0000XX-NZ for emacs-orgmode@gnu.org; Sun, 15 Sep 2013 07:52:51 -0400 Received: by mail-pb0-f44.google.com with SMTP id xa7so3013494pbc.3 for ; Sun, 15 Sep 2013 04:52:50 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: aditya siram Cc: emacs-orgmode@gnu.org aditya siram writes: > Thanks for your feedback and your work on org-babel! > I'm happy you're finding it useful. > > Oops, the maintain-point was a hold-over and isn't actually used in the > code. I'll remove it. > > I will incorporate your suggestions. > > However, regarding the cascading if statements, how would I use `cond` when > the predicates are `and`ed and when I need different behavior in the else > cases? > Maybe cascading if statements are the best thing here. Perhaps changing the order of the then/else branches could ensure the conditionals are still visible from the branches, but this is an exceedingly minor point. I guess any use of cond could easily get overly verbose. Please disregard this suggestion. Cheers, > > > On Sat, Sep 14, 2013 at 10:44 AM, Eric Schulte wrote: > >> aditya siram writes: >> >> > Attached is a patch that fixes a bug with jumping from source block back >> to >> > the Org file. The problem is that the current detangling behavior does >> not >> > take the :padlline flag into account. This stopped. >> > >> > Hopefully this is helpful to others ... >> > -deech >> > >> >> Hi deech, >> >> Please see the Org-mode contribution instructions at [1]. A patch of >> this length would require that you fill out the FSF copyright assignment >> paperwork before the patch could be applied. >> >> As for the content of the patch, my only question is why do you add an >> optional maintain-point argument to `org-babel-tangle-jump-to-org'? Is >> there ever a case when you would not want to maintain the point? >> >> Of much less importance I have a couple of stylistic notes about the >> code which are largely unrelated to its functionality and are included >> to make future changes easier to read and because I'm a cranky old lisp >> programmer. >> >> - you should indent the code s.t. no lines are longer than 79 characters >> - comments which float after code (e.g., ";; end of first delimiter") >> should only use 1 ; character >> - the series of if statements (if should-be-padded... if >> possibly-padded... if actually-padded...) would be more legible if >> written as a single `cond' form. >> >> Thanks for this change. It appears to pass all tests, so after the >> above have been addressed I'd be very happy to apply it. >> >> Thanks for contributing, this is much appreciated! >> >> If you have the time and inclination to include a test which fails >> without this patch applied that would be icing on the cake. >> >> Best, >> >> Footnotes: >> [1] http://orgmode.org/worg/org-contribute.html >> >> -- >> Eric Schulte >> https://cs.unm.edu/~eschulte >> PGP: 0x614CA05D >> -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D