emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>
Subject: Re: [bug] [babel] babel corrupts undo history
Date: Sat, 22 Mar 2014 00:40:38 +0100	[thread overview]
Message-ID: <87bnwzktmx.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAJcAo8sFf7fxvyOyETb7UnsrfLNeHiw2ZA+RGM+hM62tWJ9sPA@mail.gmail.com>	(Samuel Wales's message of "Fri, 21 Mar 2014 15:42:49 -0700")

Hi Samuel,

Samuel Wales <samologist@gmail.com> writes:

>   c-c '
>   edit
>   c-c '
>   edit
>   undo
>   undo OOPS the source edit is skipped over what just happened?
>   c-c '
>   undo OOPS the undo changes are all gone where did they go?

The changes happen in different buffers, there is no reason to
expect undo to let you undo changes you made from another buffer.
Or is it something something you see elsewhere in Emacs?

Agenda undo is different: manipulations in the agenda modify
the source buffer, so undo in the agenda should undo in the
source buffer.

In *Org Src*, manipulation are reflected in the source buffer
only when you save the *Org Src* buffer or when you exit it.
When you save, you can undo in the *Org Src* buffer, and changes
will be be reflected in the source buffer at the time you exit
the temporary buffer.  When you exit the buffer, there is no
undo problem left.

> and at worst there is buffer corruption.

Sorry to ask it again, but please let me know about a reprocible
recipe, I could not reproduce the problem you have.

> it is much better to not skip an entire set of changes + no bugs than
> "the user will never want to see the indentation adding so let's
> pretend it doesn't exist".

That's not my reasoning, which is "undo applies to manual changes.

-- 
 Bastien

  parent reply	other threads:[~2014-03-21 23:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  1:13 [bug] [babel] babel corrupts undo history Samuel Wales
2013-08-28 14:42 ` Eric Schulte
2013-08-28 16:03   ` Aaron Ecay
2013-08-28 18:52     ` Eric Schulte
2013-08-28 19:41       ` Samuel Wales
2013-08-28 19:43         ` Samuel Wales
2013-08-28 19:51           ` Samuel Wales
2013-10-28 19:17             ` Aaron Ecay
2013-10-28 19:45               ` Samuel Wales
2013-10-28 20:07                 ` Aaron Ecay
2013-10-28 21:26                   ` Samuel Wales
2014-03-10  2:46                     ` Samuel Wales
2014-03-18 20:48                       ` Bastien
2014-03-21 21:34                         ` Samuel Wales
2014-03-21 22:07                           ` Bastien
2014-03-21 22:42                             ` Samuel Wales
2014-03-21 22:45                               ` Samuel Wales
2014-03-21 23:40                               ` Bastien [this message]
2014-03-22  0:11                                 ` Samuel Wales
2014-03-22  0:18                                   ` Bastien
2014-03-22  0:37                                     ` Samuel Wales
2014-03-22  0:44                                       ` Samuel Wales
2014-03-22  8:43                                         ` Bastien
2014-03-22  8:57                                           ` Samuel Wales
2013-08-28 17:08   ` Samuel Wales
2013-08-28 17:18     ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnwzktmx.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=samologist@gmail.com \
    --cc=schulte.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).