a patch to org.el of git version

a patch to org.el of git version

[Tokuya Kameshima]

Hi,

This is a tiny patch to `org-show-children' which shoule be an
interactive function but not.

Thanks,
--Tokuya

----------------------------------------------------------------------
diff --git a/lisp/org.el b/lisp/org.el
index ce80129..7a58568 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -24902,6 +24902,7 @@ modified."
   "Show all direct subheadings of this heading.
 Prefix arg LEVEL is how many levels below the current level should be shown.
 Default is enough to cause the following heading to appear."
+  (interactive "P")
   (save-excursion
     (org-back-to-heading t)
     (let* ((current-level (funcall outline-level))

Re: a patch to org.el of git version

[Nicolas Goaziou]

Hello,

Tokuya Kameshima <kametoku@gmail.com> writes:

> This is a tiny patch to `org-show-children' which shoule be an
> interactive function but not.

Thank you. However, `org-show-children' is not meant to be interactive,
because its functionality is incomplete within Org. It also needs
`org-show-entry'.

In any case, I fixed its docstring since it was misleading.

Regards,

-- 
Nicolas Goaziou

Re: a patch to org.el of git version

[Tokuya Kameshima]

Hi Nicolas,

Thank you for the update.
But it looks like `org-show-children' is a replacement of `show-children'.
Actually the key bind for `show-children' (C-c TAB in my case) is remapped
to `org-show-children' as below.

org.el:5733:
> (define-key org-mode-map [remap show-children] 'org-show-children)

When I typed C-C TAB on an org-mode buffer, I got the following error:

    Wrong type argument: commandp, org-show-children

Thanks,
--Tokuya

On Tue, 22 Sep 2015 21:27:08 +0200,
Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
> 
> Tokuya Kameshima <kametoku@gmail.com> writes:
> 
> > This is a tiny patch to `org-show-children' which shoule be an
> > interactive function but not.
> 
> Thank you. However, `org-show-children' is not meant to be interactive,
> because its functionality is incomplete within Org. It also needs
> `org-show-entry'.
> 
> In any case, I fixed its docstring since it was misleading.
> 
> Regards,
> 
> -- 
> Nicolas Goaziou

Re: a patch to org.el of git version

[Nicolas Goaziou]

Tokuya Kameshima <kametoku@gmail.com> writes:

> But it looks like `org-show-children' is a replacement of `show-children'.
> Actually the key bind for `show-children' (C-c TAB in my case) is remapped
> to `org-show-children' as below.
>
> org.el:5733:
>> (define-key org-mode-map [remap show-children] 'org-show-children)
>
> When I typed C-C TAB on an org-mode buffer, I got the following error:
>
>     Wrong type argument: commandp, org-show-children

You are right. This is now fixed. Thank you.

Regards,