From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Gr=C3=A9goire?= Jadi Subject: Re: [PATCH] Fix `org-capture-templates' type declaration Date: Sun, 25 Oct 2015 14:34:50 +0100 Message-ID: <87bnbngjgl.fsf@univ-nantes.fr> References: <87h9lg88mh.fsf@univ-nantes.fr> <87fv0zbast.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqLRo-0002kZ-Sx for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 09:34:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqLRl-00070h-Mv for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 09:34:56 -0400 Received: from smtptls1-lmb.cpub.univ-nantes.fr ([193.52.103.110]:43038 helo=smtp-tls.univ-nantes.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqLRl-0006zY-HU for emacs-orgmode@gnu.org; Sun, 25 Oct 2015 09:34:53 -0400 In-reply-to: <87fv0zbast.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org Mode --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Nicolas Goaziou writes: > Hello, Hi, Thanks for the reply. > Gr=C3=A9goire Jadi writes: > >> The attached patch fix the type declaration of org-capture-templates by >> allowing the user to use file, variable, function and sexp as target's >> file to match the documentation > > Thank you. > >> - (file :tag " File")) >> + (choice :tag " File" >> + file variable function sexp)) > > Shouldn't there be an entry for each type instead of stuffing everything > within "File" descriptor ? With my patch, the customization interface looks like this =2D for a file : Target location: Value Menu File: File: Value Menu File: ~/org/notes.org =2D for a variable : Target location: Value Menu File: File: Value Menu Variable: nil =2D for a function : Target location: Value Menu File: File: Value Menu Function: ignore =2D for an Emacs Lisp form : Target location: Value Menu File: File: Value Menu Lisp expression: nil What kind of rendering do you think would be better/clearer? Best, > Regards, =2D-=20 Gr=C3=A9goire Jadi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWLNp6AAoJEBNzVHcrZRiUuTQP/izSJxrGsYjGZeVkdKfXz88F 0VP0nEzPUIjRzamOsLQiXRm0lGd3C+zsmHVAh99gphD8E1V8FLUWbtkqQcZLQDzX MIPcq8Rty/dTB0N2ENNM2eo9Q2KY2GStGg+06l1NfyCkQqMtht/FCaZiCReQhtSf mkl4Guw8MKU8KWFU1ulM5MTYGVy2e9Cw16FN375TzCIQbWL1tZzOY3bqmBefOkZz 4lBqRXy25xaTq48AQXIH/YIQMihS7OnZdM5xqLqHH99dyVTPasVyLr4vLOToUhR6 KTlLl7HEpdGecGDL3xNxiUr4nYqk6GUR1d+XSdKWeJyjnA2mJqG06AT+w4YedPGB fXSSwrQUPAKmbFZrUuNx9Gm+qpEUc8CZ3Q/NyiMbdlQti0lzC7LuCNPpbZdmz70x rXKqiLt+BdP3Nr2eY8WuuOcpQ2rUD4jLghHA1PPQ0l/UNW/oWos4P5k2E6epJi6V P02qX0EMGNM2GHrLtUh0d/FVYFyH8MBjGrkCbXpE7bhcKfQ8jUKt5xbyy7PRd8Gt q/TP3cnZ0iuSIbWQV8NacxVuh0ac5vo+GwW0tW6E2aAV4bNVkiRXkkexe0EPl8zb G/5YaGlayX8GDP9Iho1rGpz8yQjSK/lrmsYSD97QsMhOIR7rYptky0t3cAOqmLIY P4FEGxRphRB4dcAUxLvu =NJM7 -----END PGP SIGNATURE----- --=-=-=--