From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: About org-sort -> org-sort-list with custom sort function
Date: Sun, 07 May 2017 12:00:46 +0200 [thread overview]
Message-ID: <87bmr57zqp.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vapd5qb0.fsf@kyleam.com> (Kyle Meyer's message of "Sat, 06 May 2017 22:55:15 -0400")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> I'm a bit confused about why org-call-with-arg is necessary because I
> think call-interactively already propagates the current prefix argument,
> but perhaps I'm missing some subtlety here. Either way ...
I thought the same. I think we can replace `org-call-with-arg' with
`call-interactively' in master.
>> The problem is that if you choose ?f (sorting with custom key function),
>> then org-sort-list expects another argument, the compare-func, which is
>> not passed to it.
>>
>> IMHO, there are two ways to solve this
>>
>> 1. Ask for the compare-func in org-sort-list, as it does for the
>> getkey-func. A default value could be provided for compare-func,
>> e.g., string<, <, etc. Or
>> 2. Restrict the return type to a string (or integer) so that we could
>> fix the compare-func
I'd rather have 1.
Actually, there's some confusion in `org-sort-list' about how
getkey-func and compare-func are handled. For example, the question
asked to bind GETKEY-FUNC is "Sort using function: ", which should
really be asked for COMPARE-FUNC.
IOW, we need to move this question to COMPARE-FUNC and ask a new one for
GETKEY-FUNC.
> And I think it's OK to not expose compare-func to the interactive
> caller. In cases where sort-subr's default behavior won't do and a user
> wants to supply a value for compare-func, they can create their own
> command that wraps a non-interactive org-sort-list call.
I disagree. getkey-func and compare-func work hand in hand. You cannot
let users provide one but not the other without crippling functionality.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-05-07 10:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 19:36 About org-sort -> org-sort-list with custom sort function Zhitao Gong
2017-05-07 2:55 ` Kyle Meyer
2017-05-07 10:00 ` Nicolas Goaziou [this message]
2017-05-07 14:20 ` Kyle Meyer
2017-05-07 15:37 ` Kyle Meyer
2017-05-08 9:48 ` Nicolas Goaziou
2017-05-08 15:24 ` Kyle Meyer
2017-05-08 16:23 ` Nicolas Goaziou
2017-05-08 16:45 ` Kyle Meyer
2017-05-08 16:48 ` Nicolas Goaziou
2017-05-09 19:47 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47 ` Nicolas Goaziou
2017-05-12 1:48 ` Kyle Meyer
2017-05-12 7:10 ` Nicolas Goaziou
2017-05-13 14:50 ` [PATCH v2] " Kyle Meyer
2017-05-14 8:24 ` Nicolas Goaziou
2017-05-14 13:45 ` Kyle Meyer
2017-05-14 16:51 ` Nicolas Goaziou
2017-05-14 20:54 ` Kyle Meyer
2017-05-17 12:32 ` Nicolas Goaziou
2017-05-09 4:10 ` About org-sort -> org-sort-list with custom sort function Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmr57zqp.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
--cc=zhitaao.gong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).