emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>,
	Jorge Morais Neto <jorge13515@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: Bug: Org loses data if the user types C-u C-c C-c while composing a state change note [9.0.9 (9.0.9-elpaplus @ /home/jorge/.emacs.d/elpa/org-plus-contrib-20170622/)]
Date: Sat, 01 Jul 2017 15:19:08 -0400	[thread overview]
Message-ID: <87bmp4vuc3.fsf@kyleam.com> (raw)
In-Reply-To: <87vaniv6dd.fsf@nicolasgoaziou.fr>

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

[...]

> FWIW, long ago, I added
>
>   (defun ngz-org-capture-hook-handler ()
>     (define-key org-capture-mode-map "\C-x\C-s" 'org-capture-finalize)
>     (define-key org-capture-mode-map "\C-c\C-c" 'org-ctrl-c-ctrl-c))
>   (add-hook 'org-capture-mode-hook 'ngz-org-capture-hook-handler)
>
> to my config file. I'm pretty happy with it.
>
> One solution would be to have C-x C-s (or some other binding, I don't
> really mind) calling `org-finish-function' instead of the very busy C-c
> C-c. 
>
> C-x C-s makes sense as Log buffers are not attached to any file, so
> `save-buffer' is morally equivalent to C-x C-w, aka `write-file'.
>
> Fellow Orgers, WDYT?

On the master branch, I'd be in favor of making a separate command for
calling org-finish-function and binding it to C-x C-s.  I'd also be OK
with changing org-capture-finalize's binding to C-x C-s.

On maint, can this issue be solved by just removing the prefix argument
check from org-store-log-note?  AFAICS, the prefix argument behavior
isn't documented anywhere, and the same behavior is already available
through org-kill-note-or-show-branches (C-c C-k).

-- 
Kyle

  reply	other threads:[~2017-07-01 19:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 14:58 Bug: Org loses data if the user types C-u C-c C-c while composing a state change note [9.0.9 (9.0.9-elpaplus @ /home/jorge/.emacs.d/elpa/org-plus-contrib-20170622/)] Jorge Morais Neto
2017-06-26 20:30 ` Nicolas Goaziou
2017-07-01 19:19   ` Kyle Meyer [this message]
2017-07-01 19:55     ` Samuel Wales
2017-07-03 23:14     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmp4vuc3.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jorge13515@gmail.com \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).