From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: TIMEZONE property for ical export
Date: Sat, 19 Aug 2017 23:20:20 +0200
Message-ID: <87bmnbjluz.fsf@nicolasgoaziou.fr>
References: <87ziawx1f7.fsf@ericabrahamsen.net>
	<87fucolzv5.fsf@nicolasgoaziou.fr> <87a82vv5up.fsf@ericabrahamsen.net>
	<87k21zjr6x.fsf@nicolasgoaziou.fr> <87fucns553.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1djBAR-0000Eb-Fr
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 17:20:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1djBAO-00006F-Aj
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 17:20:27 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:60683)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1djBAO-0008SY-3l
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 17:20:24 -0400
In-Reply-To: <87fucns553.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Sat, 19 Aug 2017 12:56:40 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> It's a little strange, because the manual section for this specifically
> mentions the inheritance of the LOCATION property, but the code doesn't
> do it. Shall I add it in? It makes sense for LOCATION and TIMEZONE to be
> inheritable, but not SUMMARY and DESCRIPTION, of course.
>
> If I add inheritance, that will look like this, right?
>
> (tz (org-export-get-node-property :LOCATION entry
>                                   (org-property-inherit-p :LOCATION)))

It should be:

  (org-property-inherit-p "LOCATION")

> That could also be a separate, second commit.

I think that would be better.

> I've added an ORG-NEWS entry. The patch in my last message was done with
> git format-patch, isn't that commit message okay?

It is. I just need to read better.

Regards,