emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "N. Raghavendra" <nyraghu27132@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: org-babel-do-load-languages
Date: Fri, 04 May 2018 08:08:13 +0530	[thread overview]
Message-ID: <87bmdwkuwa.fsf@gmail.com> (raw)
In-Reply-To: <87in84rfim.fsf@gmail.com> (Aaron Ecay's message of "Thu, 03 May 2018 15:16:17 +0100")

At 2018-05-03T15:16:17+01:00, Aaron Ecay wrote:

> In principle, you are correct.  However:
>
>> I wonder if something like
>>
>> ------------------------------------------------------------
>> (defun org-babel-do-load-languages (languages)
>
> If we change the arity of the function in this way, usersʼ
> configurations will break.  We could deprecate the old arity-2 calling
> convention, but continue to support it (and give warnings when it is
> used) long enough for users to change their configurations.
>
> Is it worth it though?  Why not just add a docstring to the existing
> function that explains its calling convention and call it a day?

This is a good solution.

>> (defcustom org-babel-load-languages '((emacs-lisp . t))
>>    ...
>>    :set #'(lambda (sym value)
>>             (ignore sym)
>
> You can achieve the same by naming the argument _sym without calling
> ignore.  Underscore-prefixed names are better (in general) than
> ignore, since the byte compiler will warn if you try to access their
> value (whereas, AFAIK, there is no warning if you access an ignore-d
> variable, and thus ignore may be mistakenly misleading.  Since the
> function is so short in this case, the issue doesnʼt really arise).

Thanks for that explanation too, I didn't know that.

Regards,

Raghu.

--
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

  parent reply	other threads:[~2018-05-04  2:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 11:19 org-babel-do-load-languages N. Raghavendra
2018-05-03 11:38 ` org-babel-do-load-languages N. Raghavendra
2018-05-03 13:07 ` org-babel-do-load-languages Aaron Ecay
2018-05-03 13:54   ` org-babel-do-load-languages N. Raghavendra
     [not found]     ` <87in84rfim.fsf@gmail.com>
2018-05-04  2:38       ` N. Raghavendra [this message]
2018-05-03 19:58 ` org-babel-do-load-languages Nicolas Goaziou
2018-05-04  2:31   ` org-babel-do-load-languages N. Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmdwkuwa.fsf@gmail.com \
    --to=nyraghu27132@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).