From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Bad string comparison in org-all-archive-files (org 9.1.14) Date: Thu, 01 Nov 2018 22:47:13 +0100 Message-ID: <87bm78bhcu.fsf@nicolasgoaziou.fr> References: <4ab6e236-0145-2cf6-446a-c969ca8288d1@bredband2.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:58660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gILCc-0005zG-0v for emacs-orgmode@gnu.org; Thu, 01 Nov 2018 18:12:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gILCS-0008Pv-NY for emacs-orgmode@gnu.org; Thu, 01 Nov 2018 18:12:30 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47491) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gILCO-0008Mw-Up for emacs-orgmode@gnu.org; Thu, 01 Nov 2018 18:12:23 -0400 In-Reply-To: <4ab6e236-0145-2cf6-446a-c969ca8288d1@bredband2.com> (Nils Gustafsson's message of "Fri, 26 Oct 2018 17:50:57 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nils Gustafsson Cc: emacs-orgmode@gnu.org Hello, Nils Gustafsson writes: > I stubled upon this while trying to work out why my clocktables > weren't behaving as expected. In one of my org files I have several > large trees set up to use different archive files via :ARCHIVE: > properties, and the clocktable I added with :scope file-with-archives > seemed to be ignoring those archives. > > Except it worked fine when I used a default archive for the whole > file, or added a custom one using #+ARCHIVE: instead. After some > experimenting and digging around in the source code I've found that > the actual problem is a bad string comparison in a function called > org-all-archive-files in org-archive.el. > > > The issue: > > The real problem turns out to be that org-all-archive-files does not > do what it says on the can. It should list all archive files for the > current buffer, but will fail to pick up archive files listed in > :ARCHIVE: properties. > > To reproduce, make a new org file called temp.org (or your choice of > name) containing something like: > > * Test-heading > :PROPERTIES: > :ARCHIVE: test_archive:: > :END: > > > Then create an empty file called test_archive in the same directory, > and try calling (message "archives: %s" (org-all-archive-files)) in > that buffer. > > > Expected output: "archives: (/some/path/test_archive)" > > Actual output: "archives: nil" > > > The cause: > > Specifically the error is in this part of org-all-archive-files > starting on line 170 of org-archive.el (original indentation not > preserved): > > > (when (save-match-data > (if (eq (match-string 1) ":") (org-at-property-p) > (eq (org-element-type (org-element-at-point)) 'keyword))) ... > > > That (eq (match-string 1) ":") always fails. Replacing eq with string= > in that expression seems to restore the expected behaviour: > org-all-archive-files no longer ignores archive files listed in > :ARCHIVE: properties. And indeed, it resolves the clocktable issue I > was having as well. Indeed. I applied your fix. Thank you for the analysis! Regards, -- Nicolas Goaziou