From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com>
Subject: Org agenda -- checking for invisible tasks after filtering...
Date: Sun, 15 Dec 2019 13:52:28 +0100
Message-ID: <87bls9kayb.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47357)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <c.schwarzgruber.cs@gmail.com>) id 1igTO0-0006OE-0G
 for emacs-orgmode@gnu.org; Sun, 15 Dec 2019 07:52:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <c.schwarzgruber.cs@gmail.com>) id 1igTNy-0002Db-Re
 for emacs-orgmode@gnu.org; Sun, 15 Dec 2019 07:52:35 -0500
Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:42568)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <c.schwarzgruber.cs@gmail.com>)
 id 1igTNy-00028Z-K2
 for emacs-orgmode@gnu.org; Sun, 15 Dec 2019 07:52:34 -0500
Received: by mail-wr1-x431.google.com with SMTP id q6so3869780wro.9
 for <emacs-orgmode@gnu.org>; Sun, 15 Dec 2019 04:52:32 -0800 (PST)
Received: from lap-02
 (2a02-8388-07c6-b201-76f6-abea-ade1-c494.cable.dynamic.v6.surfer.at.
 [2a02:8388:7c6:b201:76f6:abea:ade1:c494])
 by smtp.gmail.com with ESMTPSA id f1sm17424064wru.6.2019.12.15.04.52.30
 for <emacs-orgmode@gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sun, 15 Dec 2019 04:52:30 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hey!

I'm a contributor of `org-super-agenda`
https://github.com/alphapapa/org-super-agenda, `org-super-agenda` lets you group
tasks into blocks. However, `org-super-agenda` doesn't consider filtering, which
might leave you with empty groups.

To solve that, I created a PR (https://github.com/alphapapa/org-super-agenda/pull/77)
which advices `org-agenda-filter-apply` and `org-agenda-finalize`
(https://github.com/alphapapa/org-super-agenda/pull/77/files#diff-465f82cd8ad2c42f0cebb190be6f58abR305).

Both are calling the same function `org-super-agenda--hide-or-show-groups`
(https://github.com/alphapapa/org-super-agenda/pull/77/files#diff-465f82cd8ad2c42f0cebb190be6f58abR1114).

In that function I check for the property `'invisible`. If all tasks in a group are
invisible the group gets hidden too.

The question is now, is it possible to further reduce the advised functions to
just one advised function.


best,

Christian