emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christian Schwarzgruber <c.schwarzgruber.cs@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Org agenda -- checking for invisible tasks after filtering...
Date: Sun, 15 Dec 2019 13:52:28 +0100	[thread overview]
Message-ID: <87bls9kayb.fsf@gmail.com> (raw)

Hey!

I'm a contributor of `org-super-agenda`
https://github.com/alphapapa/org-super-agenda, `org-super-agenda` lets you group
tasks into blocks. However, `org-super-agenda` doesn't consider filtering, which
might leave you with empty groups.

To solve that, I created a PR (https://github.com/alphapapa/org-super-agenda/pull/77)
which advices `org-agenda-filter-apply` and `org-agenda-finalize`
(https://github.com/alphapapa/org-super-agenda/pull/77/files#diff-465f82cd8ad2c42f0cebb190be6f58abR305).

Both are calling the same function `org-super-agenda--hide-or-show-groups`
(https://github.com/alphapapa/org-super-agenda/pull/77/files#diff-465f82cd8ad2c42f0cebb190be6f58abR1114).

In that function I check for the property `'invisible`. If all tasks in a group are
invisible the group gets hidden too.

The question is now, is it possible to further reduce the advised functions to
just one advised function.


best,

Christian

             reply	other threads:[~2019-12-15 12:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 12:52 Christian Schwarzgruber [this message]
2020-02-03 19:29 ` Org agenda -- checking for invisible tasks after filtering Bastien
2020-02-16 10:13   ` Christian Schwarzgruber
2020-02-16 23:47     ` Bastien
2020-02-17 15:49       ` Christian Schwarzgruber
2020-02-17 17:44         ` Bastien
2020-02-17 20:55           ` Christian Schwarzgruber
2020-02-17 23:13             ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bls9kayb.fsf@gmail.com \
    --to=c.schwarzgruber.cs@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).