From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: RE: attachment: link type export to HTML invalid attach dir Date: Fri, 14 Feb 2020 02:42:15 +0000 Message-ID: <87blq1evp4.fsf@kyleam.com> References: <87eevyud9u.fsf@nicolasgoaziou.fr> <87pnfhrob4.fsf@nicolasgoaziou.fr> <871rrvrw0b.fsf@nicolasgoaziou.fr> <87muairkam.fsf@nicolasgoaziou.fr> <87y2th0yc7.fsf@nicolasgoaziou.fr> <878sle1ng9.fsf@nicolasgoaziou.fr> <875zgausnb.fsf@nicolasgoaziou.fr> <87o8u2tbhg.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:40526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2Qvz-0001wL-3B for emacs-orgmode@gnu.org; Thu, 13 Feb 2020 21:42:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2Qvx-0000xc-Ek for emacs-orgmode@gnu.org; Thu, 13 Feb 2020 21:42:26 -0500 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Gustav =?utf-8?Q?Wikstr=C3=B6m?= , Nicolas Goaziou Cc: Bastien Guerry , "emacs-orgmode@gnu.org" Gustav Wikstr=C3=B6m writes: >> Gustav Wikstr=C3=B6m writes: >>=20 >> > Ah, you mean the reference on line 3216. No, I don't think it can be >> > removed. And I honestly don't think it should be either. It's there to >> > let attachment links mirror the peculiarities of file links. It's >> > needed for feature compatibility. I don't see the issue with that. >> > It's a core link type and it needs the information. That particular >> > logic doesn't affect the parse tree. It's there only to give >> > attachment links the same properties as file links. >>=20 >> I disagree. This is not a core link type. The issue is that the parser >> should self-contained. Please use a different way to obtain the >> information; we already discussed it and suggested multiple solutions. > > Maybe time for Bastien to step in. Because I can't remove the > reference to attachment in org-element.el without breaking it's > functionality. Which, btw, was broken before adding the reference in > org-element.el. The thing that started this discussion in the first > place. We're in a better place now. It seems unfair to say you can't remove it because it would break functionality. You committed 20d293b4a (Give link parser knowledge of attachment link expanded path, 2020-01-18) without posting it to the list [0] and giving Nicolas a chance to comment, which you've agreed was too hasty [1]. Misjudging the situation is of course okay, but please don't use that as a reason to keep a change that would not have landed if you had submitted it for discussion. [0]: https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00155.html [1]: https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00162.html