From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id lYwWK0gOFV+8BQAA0tVLHw (envelope-from ) for ; Mon, 20 Jul 2020 03:23:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id MIlmJkgOFV88FAAAbx9fmQ (envelope-from ) for ; Mon, 20 Jul 2020 03:23:52 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71FCA940225 for ; Mon, 20 Jul 2020 03:23:51 +0000 (UTC) Received: from localhost ([::1]:54122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxMP7-0003IM-FJ for larch@yhetil.org; Sun, 19 Jul 2020 23:23:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxMOk-0003IB-Ky for emacs-orgmode@gnu.org; Sun, 19 Jul 2020 23:23:26 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:61772) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxMOh-0006i0-Ta for emacs-orgmode@gnu.org; Sun, 19 Jul 2020 23:23:26 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 989D7DBE1D; Sun, 19 Jul 2020 23:23:20 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=Zirbo9n62JSBFbokUwUqAEAMxD4=; b=osCwHO n6GH3tYiqE5VeWBl+BUvXaAzvz6DWtf7pFpzUzNJ+vgC/uOKoKoR5/O6YhkPn1c4 OcVQSVjhNeFkuJQUwvyVdEK5HIFDNtvWKAvWIFKfYNEG6bq0zZxrPgUkci2/VONN nc/qu/E4Zc5IQWsIhMFUuHl/gq5tu57KSHS2g= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 90577DBE1C; Sun, 19 Jul 2020 23:23:20 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=APSqeohjOZznngqqfeEriurOGT3J9vsiEOg3hq/OkB0=; b=x2cjHGFneYvl6wF6iGTdh0RuLmflWBJAypYkXm7W+m1/U3IAitqgJ4FfcYYgJrVJEZPzhRAZpk0QRd2zxaO1wrsorfD4L2navU+l/1iRL00WGekq6DNqAbCzd2f20gB8maWm6o0No6QGkSLkrwlE2jJi22pGq66M5J80ZaL9Xa4= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id EFA79DBE1B; Sun, 19 Jul 2020 23:23:17 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Clemens Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command In-Reply-To: <6afc1c4b-9846-6081-aa3e-0496226e135a@posteo.de> References: <6afc1c4b-9846-6081-aa3e-0496226e135a@posteo.de> Date: Sun, 19 Jul 2020 23:23:16 -0400 Message-ID: <87blkaeuor.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5AE20BFA-CA38-11EA-91C1-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/19 23:23:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=osCwHO n; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=x2cjHGFn; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: 1Gdc8C+C/HTh Clemens writes: > Usage of org-set-tags-command can be improved by using > completing-read-multiple so you continue to get completion after the > first tag. > > This is my first contribution to org I followed > https://orgmode.org/worg/org-contribute.html and hope I got everything > right. Thanks! You got the process right. Note, though, that org-set-tags-command already supports completing multiple tags through org-tags-completion-function, which it passes as the COLLECTION argument to completing-read. In order to see that in action, you may need to tell the completion library you use to fall back to the built-in completing-read. As an example, I use Helm and have this in my configuration: (add-to-list 'helm-completing-read-handlers-alist '(org-set-tags-command))