emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Clemens <clemens.radermacher@posteo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command
Date: Sun, 19 Jul 2020 23:23:16 -0400	[thread overview]
Message-ID: <87blkaeuor.fsf@kyleam.com> (raw)
In-Reply-To: <6afc1c4b-9846-6081-aa3e-0496226e135a@posteo.de>

Clemens writes:

> Usage of org-set-tags-command can be improved by using 
> completing-read-multiple so you continue to get completion after the 
> first tag.
>
> This is my first contribution to org I followed 
> https://orgmode.org/worg/org-contribute.html and hope I got everything 
> right.

Thanks!  You got the process right.

Note, though, that org-set-tags-command already supports completing
multiple tags through org-tags-completion-function, which it passes as
the COLLECTION argument to completing-read.  In order to see that in
action, you may need to tell the completion library you use to fall back
to the built-in completing-read.  As an example, I use Helm and have
this in my configuration:

    (add-to-list 'helm-completing-read-handlers-alist
                 '(org-set-tags-command))


  parent reply	other threads:[~2020-07-20  3:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19 12:49 [PATCH] Use completing-read-multiple for org-set-tags-command Clemens
2020-07-19 14:26 ` Clemens
2020-07-19 14:58   ` Clemens
2020-07-19 14:59   ` Clemens
2020-07-20  3:23 ` Kyle Meyer [this message]
2020-07-20  6:03   ` Clemens
2020-07-22  4:26     ` Kyle Meyer
2020-07-22  7:04       ` Clemens
2020-07-22  7:16       ` Clemens
2020-07-22 12:37         ` Clemens
2020-07-23  4:37           ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blkaeuor.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=clemens.radermacher@posteo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).