From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MO76DhIEOl+ZLQAA0tVLHw (envelope-from ) for ; Mon, 17 Aug 2020 04:14:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qLLvChIEOl9qUgAAB5/wlQ (envelope-from ) for ; Mon, 17 Aug 2020 04:14:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1019F940308 for ; Mon, 17 Aug 2020 04:14:09 +0000 (UTC) Received: from localhost ([::1]:45356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7WX8-0004Rw-TG for larch@yhetil.org; Mon, 17 Aug 2020 00:14:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7WWi-0004Rm-SQ for emacs-orgmode@gnu.org; Mon, 17 Aug 2020 00:13:41 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:52112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7WWg-0008E0-Dk for emacs-orgmode@gnu.org; Mon, 17 Aug 2020 00:13:40 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 9A4EC692DB; Mon, 17 Aug 2020 00:13:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=7kqKyzwWJ4KEkI++GAhoGf+TNEo=; b=vkU2kc e7QhPz6XBUWsp0hevMzITQwJ3xlMcAh4lKNIwYflH/P1FlZiQUudWwPNtTm6Uya8 qvCv2waIOcy+t0q1ilTNrIE5hRN/tX7aQM5MZT4yUMuFQ+TUp866I2THivhdmvrK zSzD8XytepwYI8oIq3Brqsm0OJzWueoTJxSHA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 92BB5692DA; Mon, 17 Aug 2020 00:13:35 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=6v9gysgxlCuV1P8TMSI9tL0FWMkYU/+UhFe3l/kNg5I=; b=0lU0A/zIhocCM9FLNBM3N9Z1JfapCyjO1AjsurCkDOFg1v5FB5+hkB6lhFF5UaTIh3iDaLU+l2uD0tSp2mOkT19Nzh5QLjYVZnmY3gc2QmUEgmZM81c68LnacaaJD31pQ0Afa3b5kQcj6XG2uTatSOWVipwuI0eWrMFT4MyiV4Q= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 17BBF692D9; Mon, 17 Aug 2020 00:13:35 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Benson Chu Subject: Re: [PATCH] Update org-clock-out-time when resolving clocks In-Reply-To: <87wo275q9f.fsf@gmail.com> References: <87wo275q9f.fsf@gmail.com> Date: Mon, 17 Aug 2020 00:13:34 -0400 Message-ID: <87blj9yknl.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 04CAC34C-E040-11EA-B2AE-01D9BED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 00:13:35 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=vkU2kc e; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=0lU0A/zI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: olZE4/itQROp Benson Chu writes: > I noticed this while using `org-resolve-clocks' when > `org-clock-continuously' was set to true. > > Let's say I clock into "Task 1" at 12:00, and then at 12:30, I start > working on "Task 2". Then, at 12:45, I notice that I forgot to clock out > of "Task 1". No worries, org-mode has `org-resolve-clocks'! So, I invoke > `org-resolve-clocks', keep 30 minutes, and then clock into "Task > 2". However, when I clock in, the clock start time is 12:45, violating > the promise that `org-clock-continuously' makes. > > This patch updates the variable `org-clock-out-time' when `org-clock-out' > gets passed an `at-time', which fixes the issue I run into. Thanks for the patch. It looks correct to me. > The patch is attached. Is there anything else I need to do? The only thing I noticed missing is a TINYCHANGE cookie... > Subject: [PATCH] org-clock.el: Update org-clock-out-time from > org-resolve-clocks > > * lisp/org-clock.el (org-clock-out): If `at-time' was passed, set > org-clock-out-time to that value. Otherwise, set it to now. ... here. I've added it when applying (bd97851c4). Thanks again.