From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kLe1JfMVlF8wSAAA0tVLHw (envelope-from ) for ; Sat, 24 Oct 2020 11:54:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oKuXIfMVlF8vaAAAbx9fmQ (envelope-from ) for ; Sat, 24 Oct 2020 11:54:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D64B59401DD for ; Sat, 24 Oct 2020 11:54:26 +0000 (UTC) Received: from localhost ([::1]:54710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWI7t-0006ll-42 for larch@yhetil.org; Sat, 24 Oct 2020 07:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWI7G-0006le-Fj for emacs-orgmode@gnu.org; Sat, 24 Oct 2020 07:53:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45646) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWI7D-0004Du-FP; Sat, 24 Oct 2020 07:53:44 -0400 Received: from [2a01:e35:2fe1:f780:5497:18cd:5079:cbdf] (port=42558 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kWI7B-0007t9-CL; Sat, 24 Oct 2020 07:53:42 -0400 Received: by guerry (Postfix, from userid 1000) id 246EE1A60E53; Sat, 24 Oct 2020 13:53:40 +0200 (CEST) From: Bastien To: Jack Kamm Subject: Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict Organization: GNU References: <87pn5uzh2i.fsf@student.kit.edu> <875z7hwuc9.fsf@gmail.com> X-Woof-Patch: applied Date: Sat, 24 Oct 2020 13:53:40 +0200 In-Reply-To: <875z7hwuc9.fsf@gmail.com> (Jack Kamm's message of "Sat, 10 Oct 2020 16:10:30 -0700") Message-ID: <87blgrn8l7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Adrian =?utf-8?Q?Kummerl=C3=A4nder?= Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: 1qLk8cWPBRJr Hi Jack and Adrian, Jack Kamm writes: > Adrian Kummerl=C3=A4nder writes: > >> I noticed that after updating to Org 9.4 many of my Python-based Org >> files fail to execute with various `io.TextIOWrapper' related error >> messages. The reason for this is that opening the exec tmpfile as `f' >> shadows this possibly user-defined variable. >> >> The attached patch fixes this problem for me. As this is my first >> time contributing to Org I am especially open for any suggestions! > > The patch looks good. I've pushed it to master, after making a couple > minor fixes to the commit message (adding a TINYCHANGE cookie and > adjusting some of the spacing). Thanks for applying the patch, I'm marking it as "applied" through Woof! adding "X-Woof-Patch: applied" in the headers. Best, --=20 Bastien