From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms11 with LMTPS
	id oEf0N+lS5V9DWgAA0tVLHw
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 25 Dec 2020 02:48:09 +0000
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id MCHQM+lS5V9sQAAA1q6Kng
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 25 Dec 2020 02:48:09 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 61FAA94042C
	for <larch@yhetil.org>; Fri, 25 Dec 2020 02:48:09 +0000 (UTC)
Received: from localhost ([::1]:51420 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1ksd9E-0000cq-8i
	for larch@yhetil.org; Thu, 24 Dec 2020 21:48:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:43216)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1ksd8a-0000ce-Qx
 for emacs-orgmode@gnu.org; Thu, 24 Dec 2020 21:47:29 -0500
Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:36559)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <yantar92@gmail.com>)
 id 1ksd8T-0002lV-VX
 for emacs-orgmode@gnu.org; Thu, 24 Dec 2020 21:47:27 -0500
Received: by mail-pj1-x102c.google.com with SMTP id l23so2001798pjg.1
 for <emacs-orgmode@gnu.org>; Thu, 24 Dec 2020 18:47:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:in-reply-to:references:date:message-id
 :mime-version:content-transfer-encoding;
 bh=ONoq+tcvQSjD+sHmEKdY9jnF7JHwc5fqqLO8AGeXUqY=;
 b=rDadMroFpXVkr1442waFqJVKIv04oXXxjMtJKvZJFr4IKAYBJ5btHjn9iFPcD0ZHO6
 +/kLxHkptPlZuY8UZid5arnvR8U2qzYJMgtQS+NqNIcAFtd1lb28GDizy9JIkKQsJGJS
 6kNTYDlfxQ4GqGCebYOWPKkux/uHfyga43TUL7rD2oXDWFH1Frbdi+xrb5+HssD97DYG
 EFnhvf+u4D5ybFCvccH9gGiknPTCPobE+bI8jvVmvqgu479C0mV/G3/Yf/rby1toGby7
 INYDc165bJKdawxwaGIBouwCddJawXhTBJXVqGS+HgZOof5nAVW6m90IE721RAHyqO4F
 f5ww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date
 :message-id:mime-version:content-transfer-encoding;
 bh=ONoq+tcvQSjD+sHmEKdY9jnF7JHwc5fqqLO8AGeXUqY=;
 b=uOKAMXRg6h0hO1EszyhyW3NThWuRsg23/c9wDEVU9leLo76Ncpr2LjP/L/AD2zAUuY
 +T3DcXbkCdSSYPJ3c9ZOPd0O65p9fChqqkFV0ThuEVnv6AMMGac3oMn7Z9EEupZVaEim
 x01dG7OpvV5sFQLmVgarGqOFE4DKu/Qtsiizh+qLeKSKzgh8n7dfCu5h+nRmYcFEC00R
 uDayM6c7byP4WVBaz6qERomz2BLxR8jkq9wdIv09B7TP269W7NAYe+luczPdwAmWjoqT
 k/Hmo8oQ6xuvRWRIUFh8KDfrhq/FY0xeAJZtHWsJIxOjFuwPnjcnOGTnNZ1y63cqdxSG
 pkJw==
X-Gm-Message-State: AOAM531We3w3U1jkTNWM8vOl6OkvwaeBGH90YPyjYJsRZw4aYgi+bM5F
 yjwjY1CklGxzhN/qN+u9VM8=
X-Google-Smtp-Source: ABdhPJyj7UwfskFTOeXaNoqMvOp1INz4GmU88YPr/wk2xYiicx7jy+LimH8BmR4pfUBZOXFU0rJlZA==
X-Received: by 2002:a17:902:c20c:b029:da:b4d4:4f42 with SMTP id
 12-20020a170902c20cb02900dab4d44f42mr32099679pll.85.1608864439527; 
 Thu, 24 Dec 2020 18:47:19 -0800 (PST)
Received: from localhost ([192.200.115.226])
 by smtp.gmail.com with ESMTPSA id 36sm22174254pgr.56.2020.12.24.18.47.17
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 24 Dec 2020 18:47:18 -0800 (PST)
From: Ihor Radchenko <yantar92@gmail.com>
To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec <kevin.legouguec@gmail.com>
Subject: Re: [9.4] Fixing logbook visibility during isearch
In-Reply-To: <8735zu7p2u.fsf@gmail.com>
References: <87h7x9e5jo.fsf@localhost> <875zc2du63.fsf@localhost>
 <87wo4en8qk.fsf@nicolasgoaziou.fr> <87mu31adeu.fsf@localhost>
 <871rkcbx40.fsf@kyleam.com> <87mu301in8.fsf@localhost>
 <87lfh5vvrp.fsf@localhost> <87sgbc4qpl.fsf@gmail.com>
 <87sgbaw58y.fsf@localhost> <87pn6ew2pv.fsf@localhost>
 <8736393tlw.fsf@gmail.com> <87eemtm1ic.fsf@localhost>
 <875z83hwuc.fsf@gmail.com> <874knm61p3.fsf@localhost>
 <87r1nrdl5o.fsf_-_@gmail.com> <87r1nqjv9w.fsf@localhost>
 <87czz91v9h.fsf@gmail.com> <87v9d15dd5.fsf@localhost>
 <87blesa3mg.fsf@gmail.com> <875z4zam2s.fsf@localhost>
 <8735zu7p2u.fsf@gmail.com>
Date: Fri, 25 Dec 2020 10:51:17 +0800
Message-ID: <87bleizjh6.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=2607:f8b0:4864:20::102c;
 envelope-from=yantar92@gmail.com; helo=mail-pj1-x102c.google.com
X-Spam_score_int: -17
X-Spam_score: -1.8
X-Spam_bar: -
X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Cc: emacs-orgmode@gnu.org
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-Spam-Score: -2.52
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=gmail.com header.s=20161025 header.b=rDadMroF;
	dmarc=pass (policy=none) header.from=gmail.com;
	spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org
X-Migadu-Queue-Id: 61FAA94042C
X-Spam-Score: -2.52
X-Migadu-Scanner: scn1.migadu.com
X-TUID: 6klygQUWLVG7

K=C3=A9vin Le Gouguec <kevin.legouguec@gmail.com> writes:

> I've looked at your branch for inspiration, and my takeaway is that the
> isearch-open-invisible-temporary route might be too involved for a
> bugfix, especially if it's going to be reverted wholesale when your
> branch gets merged.  Then again, maybe I'm not smart enough to devise a
> solution.

My current plan is supporting the overlay-based approach even after
merging the branch (by default). So, overlays should be around for a
while and the issue with drawer visibility will be around as well,
unless you fix it. I will probably work on this in distant future, but
that's not the priority now.

> I wonder if the path of least resistance couldn't be found in
> org-cycle-hide-drawers: right now this function just skips over drawers
> which are covered with an invisible overlay, but maybe it should not
> skip a drawer if the overlay starts before it (i.e. the overlay is not
> specific to this drawer but covers a whole containing section).

That would defeat the purpose why the number of overlays was reduced in
Org 9.4. However, org-cycle-hide-drawers might be called in
isearch-open-invisible-temporary.

Best,
Ihor