From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gJ8+Lkyng2CJpwAAgWs5BA (envelope-from ) for ; Sat, 24 Apr 2021 07:06:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cN+zKUyng2BjNgAAbx9fmQ (envelope-from ) for ; Sat, 24 Apr 2021 05:06:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13B2B24D5D for ; Sat, 24 Apr 2021 07:06:20 +0200 (CEST) Received: from localhost ([::1]:53910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laAUk-0006pD-F3 for larch@yhetil.org; Sat, 24 Apr 2021 01:06:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laAUF-0006p6-V7 for emacs-orgmode@gnu.org; Sat, 24 Apr 2021 01:05:48 -0400 Received: from out0.migadu.com ([94.23.1.103]:41888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laAUB-0007ay-7L for emacs-orgmode@gnu.org; Sat, 24 Apr 2021 01:05:47 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1619240739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tkFddyNeUmA4xtZgl72vWpVBSYv68ZGKH7foPe5uWSk=; b=kaVPc5Bg70iPpFya/Km5OhtZuVKhLaKyCvNJLZuslqfuRh6RuQNh/ZbZHvM2pkBAh6e9sY 1rBLdbbMR+i/4BnGaQ2qu0FE0kWiiNZHI+LlrTh+A+6Ov0JgAxacl5Knr7xNGXwdCagoUb w0EifUCwBzni7h9g1f2Dzw1MrgXdDpFHPM8IsoX98nbh+Wuy1eOqt9rLlItqBF8f7gr3sa efU3w5Q/4MfEdHxB5iscmWxaMvMkNePC0C5MrQnLXv3f72BOXjq7b3bv1YG7LcUysMigpp pOJBqaaQ36/1zkThLI5LAsPdxtpzWbIuZw8kW8HT7ygh7CiAAcMD543UGaCDPw== From: Kyle Meyer To: Michael Eliachevitch Subject: Re: org-contacts.el use lexical-let not defined in cl-lib In-Reply-To: <87czul1e8p.fsf@posteo.de> References: <87czul1e8p.fsf@posteo.de> Date: Sat, 24 Apr 2021 01:05:37 -0400 Message-ID: <87bla4gtlq.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=94.23.1.103; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619240780; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tkFddyNeUmA4xtZgl72vWpVBSYv68ZGKH7foPe5uWSk=; b=px5CVLG9lnSV+sMHbDaVYzp2PF8IZJUWkVcIO6nHO+biGRpLqvLswnxFrpLOXMHoUSFTH9 SajvrjthqQLk7D+Bmtejo58OE4x6UCjI0FsWHdnVW1FqrK9tAIwu/IAd5Wowf0nMe7ggVh QklSmdggXUCc/F0LXrCtS7eXkL7cRn58CnRfzNO30qm1iMYgkiCt35yH7hZI8lEWijbFYu VbM54/harF8CB3ZTBtRyjNePn/KAphRDYNoK6S5okTG2XtEXhtUFOPMGTZrCBFfBAar3G/ 8MHH01iZNzG4zVPQc9wpO/uVBlIOMtWBAZILzqAkTYbIw59zTocFRDGcG4CQhg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619240780; a=rsa-sha256; cv=none; b=VUVsney+RGmK8ZZDobVyDOhOz7r+mVyE7bbVyANpXLmS4MmSKuBmd1Fko7uawEriNZ1hS6 JNUSYU7Dwt67wctj9PRx2pGQ8yVq9TUMMj8BBDYSaeRXPeRoaGxA41HPVXwm/oFn/iSbc6 NMKPCHLks6B5aDvRVzTFT/zHBFc9TyulOtyrwdd1y/hTUp8osYvB8g6kY/L+ZjItSjBjol DBQMJeCem7T/kPrtr+TaBTZIQOHlrP5qskObGmbSF9OebhIOE7kI38pHUbPNyHDdpWohAd z7vIryexdDJKMbq72mwP5LYSvFraup92Wi2MofWDiRn3HX+tbbbAzlgD32kPkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=kaVPc5Bg; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=kaVPc5Bg; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 13B2B24D5D X-Spam-Score: -1.44 X-Migadu-Scanner: scn0.migadu.com X-TUID: +9YxcluhZRQF Michael Eliachevitch writes: > Dear all, > > I'm not sure if this is the correct mailinglist for org-contrib > bugs. Thanks for the report. Yes, this is the place [*]. stardiviner (+cc) recently took over maintaining org-contacts.el. > I found that org-contacts.el uses `lexical-let*` which is defined in > `cl`, but it only requires `cl-lib` where it is not defined. [...] > My org version is release_9.4.5-321-ge641d3. However, I see that > on the master branch still uses lexical-let*. > > Is this a bug or some error in my configuration? Should I send an > email elsewhere or submit a bug-report? Because (require 'cl) is > deprecated, test solution would be to replace the lexical-let* > with something else like a normal let*, but I'm not confident > enough in my lisp to do this by myself. This is a bug in org-contacts.el. Loading cl was dropped in ea238b78f (contrib: move a few libraries to cl-lib in place of compile-time cl, 2015-11-06), and, as you note, it's still needed for lexical-let. I haven't looked at the org-contact's lexical-let call sites closely, but I think the way forward is to move org-contacts.el over to lexical binding and stop using anything from cl.el. stardiviner, what do you think? [*] ... though sometime soon the plan is to move contrib/ packages elsewhere, at which point I guess it mostly will depend on who is taking care of a given contrib/ package. https://orgmode.org/list/87wnzfy60h.fsf@bzg.fr