Re: [PATCH] c-csl : accept relative CSL filenames

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Emmanuel Charpentier <emm.charpentier@free.fr> writes:

> This (minuscule) patch allows to pass a relative (to the buffer's
> default directory) file name to denote the CSL style file.

Thank you. However, I'm not sure to understand the purpose of the patch.

> Rationale : this allows the use of "one-of" styles for "one-of"
> projects without overloading a defailt CSL style directory (which may
> or may not exist on a given system : think JabRef users...). Also
> useful for hacked CSL files specific to a given project.

If we expand every relative file name from `default-directory', what
happens to `org-cite-csl-styles-dir'? Your patch makes this variable
useless, doesn't it?

What about using a local `org-cite-csl-styles-dir' instead, using
file-local variables?

> +    ((and (pred (lambda (x)
> +		  (let ((fn (expand-file-name x default-directory)))
> +		    (if (file-exists-p fn) fn nil)))) file) file)

This pattern returns the relative file name, not the expanded one. It
may not be what you want.


Regards,
-- 
Nicolas Goaziou