From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wMgBKkcrpGLJrwAAbAwnHQ (envelope-from ) for ; Sat, 11 Jun 2022 07:42:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iKwUKUcrpGJRDwEAG6o9tA (envelope-from ) for ; Sat, 11 Jun 2022 07:42:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B546145D9 for ; Sat, 11 Jun 2022 07:42:31 +0200 (CEST) Received: from localhost ([::1]:55768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzttF-0006tn-Vy for larch@yhetil.org; Sat, 11 Jun 2022 01:42:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nztqG-0006lJ-Du for emacs-orgmode@gnu.org; Sat, 11 Jun 2022 01:39:24 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:55010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nztqE-0007iG-RW for emacs-orgmode@gnu.org; Sat, 11 Jun 2022 01:39:24 -0400 Received: by mail-pj1-x1031.google.com with SMTP id j7so1164531pjn.4 for ; Fri, 10 Jun 2022 22:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=kZdKBm3wvbPiBmGxO8gSIFY+qdwiA38x6bridh8vCuY=; b=Gfj2Vwsj4FhqvZ+QNeaB4Sy5gDUE05KSm8Lafo6LjSkYaQ/hGzGg12RpvboqTQQJED cjBC+9bkj7EAx/BOE7cpAj79nqCyzIDcfhcA0RsqAXxnR6aAKzJNIkOk0XY/DMpmES4O mEnOatjncPP5yQQVlpfek11+I/qS/t+jswIfTFFZ2akHOgrpcuy6gktvKVUnEsG7j4wV PcPDIv0tlK6qetx4bglIxmugnhuEk/uTUY0VibauQjpv+qs8Rf6msNpd1IGQ5wUN0Xeq M+DEovM3cPhQijUhCSz+KRVOUMNUaVXQvv+/hO8CcUH98W7vZmd0AGJwJ124Ve6RR3do pLeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=kZdKBm3wvbPiBmGxO8gSIFY+qdwiA38x6bridh8vCuY=; b=LtaNCpttU4YP920Khp+nSm/x/rav8qzIdGDpiPGhYi3ne9qNCBvxNYmOLBbcY866PC RQo3ei1SVu7aUosU1aXxRaa6qGAqbXT20MRTWjZwdZoOdp54E+/T5m4MveFGmZcI1oQ/ XlwvzcT1EuIN4IsfbNHbAYMTiqP19dwcdByO66NVCZJRaDpA9x6QUlfSF+bCQeYdAwc7 wDgOdqIBu6cnIor94rWSVFeM4OLj2dzTgGG2zv7gQtjQxTi+B1fL0yEy3SGVleMUZzo4 Wwlnr1sZ5D91n0Y00Fs+Xq1vx/9HK/SsUL2fp572M4p2+psFZ+c/2q5DoJXARICsJrIz pKrg== X-Gm-Message-State: AOAM530IlNaiI3XYMfABXopHTTEYAE7cn2L1aMEy8gXWCd6UW/fpOsa+ QAk2nv9jp+bpgWmPOsTR9pc= X-Google-Smtp-Source: ABdhPJxECavLYSYajbr0GiomHoBXbGo7SZWRz97pNjm9JAmLz57ogkHCGWZwrwfvkdKeSorCm227hQ== X-Received: by 2002:a17:903:1c8:b0:165:1395:dcb3 with SMTP id e8-20020a17090301c800b001651395dcb3mr47183363plh.76.1654925961296; Fri, 10 Jun 2022 22:39:21 -0700 (PDT) Received: from localhost ([64.32.23.62]) by smtp.gmail.com with ESMTPSA id x4-20020a170902820400b00163fbb1eec5sm653701pln.229.2022.06.10.22.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 22:39:20 -0700 (PDT) From: Ihor Radchenko To: Juan Manuel =?utf-8?Q?Mac=C3=ADas?= Cc: orgmode Subject: Re: [Patch] ob-tangle.el: New value 'ascii' for the header argument ':comments' In-Reply-To: <87o7z0tltj.fsf@posteo.net> References: <87o7z0tltj.fsf@posteo.net> Date: Sat, 11 Jun 2022 13:39:59 +0800 Message-ID: <87bkuzdahc.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=yantar92@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654926151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=kZdKBm3wvbPiBmGxO8gSIFY+qdwiA38x6bridh8vCuY=; b=h/Jx0gJidOLg3enkzG5pKJhP9LB1TNlM6azB8QJaVsm0nkf9GK8WxLMqUZAlza35coYrtW TEkp5MKCyX7bHjpAS92PnPVLP3C4vU0Xa8StIfpTH77bqiFtbodXu/jy9eaXjUL5q+wL0H cktyzNSJl2tj82GUnLDnHHE41x1NwPGi2sgYEskEgNUpNXgzwV12KtK5SsZPrcxykXvpsI aTsn+v6/AqLNEE5k+lh1rbsaiFuklWCo5d1IhwmNBR8ykU0mGl9lKCa5HEMeisrHrknPpp +lZl0BxBH4mmwCrRtWo+EqA6s+9XOrhsYOhTLkVMjKk1ZtqN4DXT6ljYnXDzIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654926151; a=rsa-sha256; cv=none; b=nwsiAXux6SbxfNWorUzwCyOTL4NPQJnE8q/wM3RuZwxbGoQ796ujFTLM8aFime4VK4bUWX d5n0NQKuXousZO7r0bqr9lA2vFkWVAwJ8KiHX/RMRZMWagm6C0CFrIJcCfIGQ0FwZfrJKT IcUf5nrihXLcfTjwzLvXdX3Pw+7XfU0m7SBfd81Gk4LbzKClFJjnPPyhvtPi56zzToNNit +ky/d/mzv6l9oowXIIvPV2ksEhL8WkAZK7U7YAmgkJlKpXUg2oWBajIB5P83PdU+nEIfGg 3dlqi2IqSKPZSN2l3wwYDGD7thtBO27nyovJq8Id+rHSUGV6U6bWM1E8DL5myw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Gfj2Vwsj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.49 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Gfj2Vwsj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4B546145D9 X-Spam-Score: -3.49 X-Migadu-Scanner: scn1.migadu.com X-TUID: STWg7FNfyHe4 Juan Manuel Mac=C3=ADas writes: > With this new value, comments are passed to the source file as plain > text, without the org metadata (keywords, property drawers, etc.). > > As usual, feedback and suggestions for this patch are greatly appreciated. > > Best regards and happy weekend, Thanks for the patch! Wouldn't it be better to supply a customization for org-babel-process-comment-text instead? I do not feel that per-src-block control on the comment type makes much sense here. Best, Ihor