From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cO9RK2RKOWQW6AAASxT56A (envelope-from ) for ; Fri, 14 Apr 2023 14:43:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0KpLKmRKOWTITgAAG6o9tA (envelope-from ) for ; Fri, 14 Apr 2023 14:43:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5816811EA9 for ; Fri, 14 Apr 2023 14:43:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnIkw-0006Bg-MF; Fri, 14 Apr 2023 08:42:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnIkv-0006BQ-OD for emacs-orgmode@gnu.org; Fri, 14 Apr 2023 08:42:21 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnIks-0002x2-4e for emacs-orgmode@gnu.org; Fri, 14 Apr 2023 08:42:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 38FCF2403B2 for ; Fri, 14 Apr 2023 14:42:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681476136; bh=RVBhN+eelgWjKAjVMOMBPjh9C8x29QykqTR9eQcArFA=; h=From:To:Cc:Subject:Date:From; b=WKl77UDHthEjXQeDHgcc2g9RkKpUNEZ+eifiU+wsWZ4hrn+Dr+f+/Kg01AwILCkNJ DPz/XZxuc0EfSkUvGA00z1trEmFX0ZzpaBnn4WsBeAzCjkMucfRBBwfG8S0X66xKst UU7hnFEKlFDXqvPmg6MZ3QyUaPGeaFwk0DELXDHmStO9TXM/ZD7I0DEsWQ4X94o90E ATsuK6CbGwlohQktyLjvrs0HMqmtMBHkPZg5PoqxLKA4fAq37GBbMkI/B0cNYWh5Ag Q5icE8IcV5J1vBXOdVoRFLIdQCCsXV8TIV3/L3aYkb5McGKPC7Jd6a4jQX0TIgxZD6 SYXIWczzAoqlw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PybgW3Ygcz9rxh; Fri, 14 Apr 2023 14:42:15 +0200 (CEST) From: Ihor Radchenko To: Andreas Gerler Cc: emacs-orgmode@gnu.org Subject: Re: [O] [PATCH] ob-eval: display error fix In-Reply-To: References: Date: Fri, 14 Apr 2023 12:44:53 +0000 Message-ID: <87bkjqmy4a.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681476196; a=rsa-sha256; cv=none; b=IIENXF6jbRUuV6zhXfMQI7E9VpWcq3YFJTu4u443n+eU3J34Kc/RxVsv5PJtDtb06g7+aw EYQXnpeRWhbMaovQn0eNrhWy9VOMmpmPuO/mjxvWzSSNGoSPaTYyLC1BXG9VMCbf5b01hl V/qVvR02pdlxfsFjU21cM7G6WW0IuyxWFNoXT3J5v8eXgWbG32n8u8WanAYAj5oXA+8N3j iTyxbOFd5ephxaGNI7Is3YMJ5XkkJnbxlHu8a+9Hs8Ep5YQAfwnScwgGbKBGS9EGLuvkhf ekGZSDY9LYmlPDMokRXk+NaFnjUoA7h3O71d5dT3+iUDKzexsdj6dL/u6E6GUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WKl77UDH; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681476196; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dIOMfSqUlOqheyP5w4CED0i1P/2oP9Fni2hKPddBXvs=; b=rrq/9sgXfmApfR0MQcNecwoqOiPMgxsxWcey01Na9YC23SoTC5EzlFkQ2BlSvfyFJH/Fu1 Sgxz4zyzYeQj0Rx6myj5Zj7tifYaxReYW6YxF1Cqx11rXMLIZihaaF3FahvwScZl1G8q1n MjTjhXOJTMUOjTCchk5ya8HdurZrvz1ZQIWzRWDJS8zm1vqBUWYoSSj5i7pTBtfawfN05W 2y0kKZ8CJCIrptKXwYyeCyzRx6UZ38d+puBXxR3IKb57ljNX3p5BCQLI0aA99qq5n0nmXO 2u8ourAS/xF7j0zOJRmsjWpYTrVIBUsmt9vnnwjscnN1OOblnKJjPhsLrEA3bw== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -4.71 X-Spam-Score: -4.71 X-Migadu-Queue-Id: 5816811EA9 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=WKl77UDH; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: HT9kgsywa8Zu Andreas Gerler writes: > * lisp/ob-eval.el: (org-babel-eval-error-notify): Display standard > error only if command exits non zero. > > The problem is that sql connections might give warnings. > Now the information is available in the *Org-Babel Error* buffer > without displaying. > If you need always display toggle org-babel-eval-error-display-notify. > I am looking at this again, and there seems to be no simple way to know which babel backend is active when org-babel-eval is invoked. I think that we can use a different approach to handle the problem with sql connections: 1. Add a new optional parameter to org-babel-eval that will disable error buffer completely or when the command exits with 0 exit code. 2. Modify org-babel-execute:sql (and maybe other backends) to pass some header argument value to `org-babel-eval'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at