From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iCkwKG4KDGXutQAAauVa8A:P1 (envelope-from ) for ; Thu, 21 Sep 2023 11:18:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iCkwKG4KDGXutQAAauVa8A (envelope-from ) for ; Thu, 21 Sep 2023 11:18:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C5CB572A2 for ; Thu, 21 Sep 2023 11:18:38 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PnVGWPKq; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695287918; a=rsa-sha256; cv=none; b=dtrVEtqXhMVCIHvyPrQlrpsx4g1iT4kObvLMRxG3C1FOaMW2pKJ95dkpro6Z0jhLYKj5mj oL4y472VlCSjGPmYSprlv2jEKytxqRrz8LaFGtW+WBVuEzxYQZV1b9uBtuQnBEEnkvadL7 ECgORUUDJwmGzSrJaPJsG73F9f/ZnqFpmp/Gkbb7rJuR9CYyL3H/XtqZfOC88LHyzt1vBx jGim73lINQ/OVcqGUK6ccA2A/fi6gr6zIO34RPVVcd3U/pUmkeN1Wb36j/zJHYTeM4xLZs R4JT+2lDpxUw7/5Jo1zMhcVPATp2AIzv0ttUxMc5bdSYRepruHLiHal3h6L0AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695287918; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=L/I//X2v6uhx3OP6pQgC7GDyFIky8kMG7/k+RpEFhDI=; b=gxcYFhu1fQdGxcTev2EMZM525mnszcbr42wwbNjA1h67x4EYd1xciTiYgCnBJ884ysUB4K a1fhEkacjvylMfQw8NUMNsXzJrh2ZRx3kIjVyNtKL+PJbleC9MOPYNw+fh8YUr/I5LOofr eaJ5UmKH1qhJaD4tJA1sQMFbTkG51NKv2PGqz4vEzRmaJa2zmBmeF3Yq4JJ/OBkR9gGVWr SnHhWpWSE/y2kETeneNNsqqvSRbfgYFyFHKgdeMGOaJ28FPRz622+NAUNuMizqP5nDWk/X rWQf5EdtcuywKXoG16umm5GfUeje7owNK4oPU8KWD9dSaJAeVIrjsC7oOQk1bA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=PnVGWPKq; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjFon-0001mA-Ln; Thu, 21 Sep 2023 05:17:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjFoZ-0001lD-HY for emacs-orgmode@gnu.org; Thu, 21 Sep 2023 05:17:47 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjFoW-0001QS-Pt for emacs-orgmode@gnu.org; Thu, 21 Sep 2023 05:17:39 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 73E94240029 for ; Thu, 21 Sep 2023 11:17:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1695287854; bh=rMIeIrIAY8eVS8MHWaExZO4GTMRIwTCo14UDlXG0gkA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=PnVGWPKqSpLkQaZ/HgE6wD9rHLswL0LwCFhoWlEiatYurWVwyPWIjI6l+VSDVf5VA O7rxktFqJLJ6ZIDg+3LGasxGrteetU2tYTQYXxLFyQq9geewCSYSHga7ya23v3/Rbj maBba6O8OgvrORB9L2HhwijvrFCh0L8A8gsBby4CPXD5F5qOYeNGe5hN3gIBnIoLiF epbin1xRUL/MysGhwVGOTusajxXJFhvMR6FNNYZx/nbexunffFDM9FrDW7Lsuqv/lO aQSmKYIzo1F6Nusz0dzStltWrOzy2OCPZsAN6x9j90ZgskcCn+qXgHnLYq9/U8PzjQ KrQ4TlzSbDVyA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RrqYT4WRfz9rxQ; Thu, 21 Sep 2023 11:17:33 +0200 (CEST) From: Ihor Radchenko To: Leo Butler Cc: Bastien , Lockywolf , "emacs-orgmode@gnu.org" Subject: Re: [PATCH] ob-maxima.el, etc. (was Re: [MAINTENANCE] On how much we can expose internals into defcustom) In-Reply-To: <87r0msx4ze.fsf@t14.reltub.ca> References: <874jkemrk2.fsf@laptop.lockywolf.net> <87cyz1ivzw.fsf@t14.reltub.ca> <874jkdhwix.fsf@localhost> <87wmx8h2b0.fsf@t14.reltub.ca> <87il8ovqeg.fsf@localhost> <87cyyvdraz.fsf@t14.reltub.ca> <87ledinrl5.fsf@localhost> <87y1hb5cb4.fsf_-_@t14.reltub.ca> <87jzsrai3x.fsf@localhost> <87ediz4ggm.fsf@t14.reltub.ca> <87ediypjzb.fsf@localhost> <87o7hyx8wq.fsf@t14.reltub.ca> <8734z99pa5.fsf@localhost> <87r0msx4ze.fsf@t14.reltub.ca> Date: Thu, 21 Sep 2023 09:18:50 +0000 Message-ID: <87bkdv28at.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.52 X-Spam-Score: -8.52 X-Migadu-Queue-Id: 4C5CB572A2 X-Migadu-Scanner: mx2.migadu.com X-TUID: kEsA0g+a4HKY Leo Butler writes: >>> +(defconst org-babel-header-args:maxima >>> + '((batch . :any) >> >> Why :any? Only two values are allowed here. >> >>> + (graphics-pkg . :any)) >> >> Same. The value is a closed list. > > I have made the change requested. > > However, beyond the documentation value, I don't see this variable's > values being used. In completion. See `pcomplete/org-mode/block-option/src'. Also, in org-lint. See `org-lint-wrong-header-argument'. > Fixed. I don't use `apropos', so I didn't see the problem (and I had > failed to absorb everything in =C2=A7D.6). M-x checkdoc checks for many of the =C2=A7D.6 conventions. > Please see the attached, revised patch. It fixes the problems that you > have identified=E2=80=93except for the way that the gnuplot terminal is > determined. I would like to leave that for a subsequent patch, mainly > because this one has become quite large. Ok. Thanks! I have one more comment on the tests: > +(ert-deftest ob-maxima/batch+verbatim+eof-error () > + "Exercise the `:batch' header argument. Send invalid input to > +Maxima." > + (unwind-protect What is the purpose of this `unwind-protect'? In its current form, it does nothing because no UNWINDFORMS are provided. > + (org-test-with-temp-text > + (format "#+name: ob-maxima/batch+verbatim+eof-error > +#+begin_src maxima :results verbatim :batch batch :cmdline --quiet > +x: > +#+end_src > +") > + (should (string-match "end of file while scanning expression\\." > + (org-babel-execute-src-block)))))) --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at