emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Anders Johansson <mejlaandersj@gmail.com>
Cc: Nicolas Goaziou <mail@nicolasgoaziou.fr>,
	org-mode-email <emacs-orgmode@gnu.org>,
	Timothy <tecosaur@gmail.com>
Subject: Re: [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items
Date: Wed, 14 Feb 2024 12:37:07 +0000	[thread overview]
Message-ID: <87bk8jusr0.fsf@localhost> (raw)
In-Reply-To: <CAKJdtO_zt-PYJsZ__FYHVoN5H74X06SSsCzJRHTrOu02OK4kAQ@mail.gmail.com>

Anders Johansson <mejlaandersj@gmail.com> writes:

> Included is a patch for the filtering (I assumed cl-intersection was
> reasonable to use since cl-lib is a requirement).
> However, I do not think this is enough, since it can cause quite
> unexpected results when canonical is used without specifying the
> format, Hence, I do think the previous patch should also be applied.
> For my case, org-duration-format is (("m") ("w") ("d") (special . h:mm)).
> This call to org-duration-from-minutes (like in org-agenda-format-item):
> (org-duration-from-minutes MINUTES nil t)
> will then result in a full format amounting to (("d")), (since
> "special" is not part of the canonical units), which is hardly what is
> expected for the agenda.

The patch breaks tests and thus cannot be applied.

May you please provide more details about the original problem you were
trying to solve? Preferably with a reproducer.

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

      reply	other threads:[~2024-02-14 12:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 14:41 [PATCH] Fix bug assuming canonical duration units in org-agenda-format-items Anders Johansson
2021-08-11  9:39 ` Nicolas Goaziou
2021-08-31 13:55   ` Timothy
2021-08-31 15:46     ` Anders Johansson
2021-08-31 18:34       ` Nicolas Goaziou
2021-09-02  7:47         ` Anders Johansson
2024-02-14 12:37           ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk8jusr0.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=mejlaandersj@gmail.com \
    --cc=tecosaur@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).