From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +NwnOjn9cmYMHAAAqHPOHw:P1 (envelope-from ) for ; Wed, 19 Jun 2024 15:46:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id +NwnOjn9cmYMHAAAqHPOHw (envelope-from ) for ; Wed, 19 Jun 2024 17:46:02 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aDnwYo7f; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718811961; a=rsa-sha256; cv=none; b=P8hcYpTzn07GyGqfB5IFR2T18OEAwA8XhqaYlNZLWFSA+hCTHigX1Wxam2Llhv5pULeskw ZavhMZrecS32inlv99UkW8sw2lIa+JxcfdImJwgByhF7EifxSi+A19BEBdJA/tVzbXP8r5 SVJiYl91fOJfP+6TloUIlgLudB9g3S1Fz5x30Wo+RpuwtFQrC1IbMuS5pKvDEwsfC5tteD 8xAGbimMfJhthKWor01lIckep06w3KDWa+kSf4Zwzx3xwyhTe4C8om09dWGzPe8p0ZjLtH QEvtfNoqx3ywoljXjWIUWL7dNUSatolksymUG7k5tnZcUs5DIhh+/Qw74e2AtA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=aDnwYo7f; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718811961; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OXFbNhyikzaWAsLW9OvDqEjBhLgWGWcN1k80vlCJCQk=; b=A6CFktsmLRBvKmwvAJ1w6tDkkMyRxXfbUMhGLh19d+JvJgb7kemi7WCcVa+bJj6f6nXgwr 8qDi7fhwHT9x/ygEkmlRLAVdKG/aTiTDJy2G9YecylfN3ZuHzolkQjTG/Xi+XkRN7IlHXI QmqWgylpgmdBTWmg/zstZYUN+Ln13Y/ltbP0D7VrcFjSN+M7+iK+u3FNvsv18dAKHjGlK2 35y7S4YJo/FK42/sQXvB+qSbVItAbK2ow3dokevJ/LIPmOfFxcwhu9IlKP6fDSxPLkdWDu nPdAseBHKQB2mzvzOf3JS4NOwj+cXjjXk9uBctpdVfDel2NBj5LFBucU31WkUQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CE8F26FED3 for ; Wed, 19 Jun 2024 17:46:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJxUr-00010E-7V; Wed, 19 Jun 2024 11:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJxUp-0000zY-Ae for emacs-orgmode@gnu.org; Wed, 19 Jun 2024 11:45:15 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJxUm-0000oY-WA for emacs-orgmode@gnu.org; Wed, 19 Jun 2024 11:45:15 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3B0E7240029 for ; Wed, 19 Jun 2024 17:45:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718811909; bh=apBEa903YX2XD+kCpeIEX6gUlDeF699ciug1HPDYtPU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=aDnwYo7ffL8yyxhPtd5a9MipXBhTOagMnuCDKNEsi6W1fiuMw8o2laeUJhRf+QJv0 EgOXfzNx/ailVlqRo6CHyChY2GswRw4EKgA04m+UopxGUE3MYXoVoUw4v82Gy4N5cx h9Yxw8sWnJxPlY17c30nYYdf/8cgTvz3ziO0OEhh39lcPWZbWlEQqVUcJQGPa3Ju6h aRHFefeF5mQitBZ6+g3YjO7wTIbh8TZU3tvJBZmf9rq6H3O3mb+wR255eBpgSD7Lyt bOkP5xSDEAU6xPNM9zsgWmA5THLQ/vsPNjrhxBTcT7UBFy7RgwyyOI2bZUN0LDOYPt zRolS1XFiA/QQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W47H76bl4z9rxL; Wed, 19 Jun 2024 17:45:07 +0200 (CEST) From: Ihor Radchenko To: Morgan Smith Cc: emacs-orgmode@gnu.org, Sanel Zukan Subject: Re: [PATCH] lisp/org-clock.el (org-clock-sum): Rewrite regex using rx In-Reply-To: References: <87r0f9b9n2.fsf@localhost> <87frvpyzrf.fsf@localhost> <875xu6aee8.fsf@localhost> Date: Wed, 19 Jun 2024 15:46:52 +0000 Message-ID: <87bk3x9bpv.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.08 X-Migadu-Scanner: mx12.migadu.com X-Spam-Score: -8.08 X-Migadu-Queue-Id: CE8F26FED3 X-TUID: 5y2n7muvA7E/ Morgan Smith writes: > So I gave up on this specific patch because I wrote a patch to just > rewrite the entire `org-clock-sum' function using org-element API. > Attached is the `org-clock-sum' rewrite patch which I've been using for > a while with no issues. I have half finished patches locally to add > more clocktable tests and to add clocktable benchmarks which is why I > hadn't submitted this yet. > > This probably belongs in this email thread instead: > https://list.orgmode.org/87y18vxgjs.fsf@localhost/ Yup. But my "to-followup" reminder came up earlier for this thread ;) I do not remember every single thread, unfortunately. > Ideally the fix in that commit should be ported to the org-element API. > Notably, the malformed clock from the email thread from that commit is > parsed a little strangely by org-element. I'm not sure what effect this > has on my rewrite patch but regardless, we should probably fix this. > Notice how ":day-end" and ":minute-end" are set but not ":hour-start" or > ":minute-start". That's expected. We have the following _syntax_ description for clock lines: https://orgmode.org/worg/org-syntax.html#Clocks ... clock: INACTIVE-TIMESTAMP-RANGE DURATION And [2012-01-01 sun. 00rr:01] is a perfectly valid timestamp without time part. Org does allow arbitrary additional text in the timestamps. (it is by design, to allow future extensions of the syntax, like the planned timezone support) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at