From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MCn0EfGDAme0YQEAe85BDQ:P1 (envelope-from ) for ; Sun, 06 Oct 2024 12:34:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MCn0EfGDAme0YQEAe85BDQ (envelope-from ) for ; Sun, 06 Oct 2024 14:34:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DS8R7VFK; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728218097; a=rsa-sha256; cv=none; b=H9rsuKDwRNpk0Z6Rq5TKAkoWeB+u5yJKNfaGuV3y/KD8OJfFTb+iuYWzDH3nigxhLlAwXP AgAMXN2GkcC9ZYhQKWVYUgCVMMxI85kovbb5IOOl9nifR2miZGvtdcNpONMpZfqjhTkChD kvivXriCc/RHQQbWGknwP9QBa3L1cpFznuON5V4Qwth9pVROhLW0rw/Cphivploc3+BXZu 81H8aRQ2spBtqvKW6kE1MGiZOskiKupYy2EMgINTrsOgZhaz/IcW/6gMU6ZzSSZ16KOfxO Li2rpmO3XvEso9GJ9WTHBO5+McIttr3dM2UtiZt9jApayQ/PJLA8EnCBvw7dBQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=DS8R7VFK; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728218097; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BSnI2YZQdTUDk9DObRfKItuMtM6w0dyg1w60VGgJLNE=; b=eNxSIhkE63jhESen+sux+DrETrAJQQDkH0b1pfQUf4wfneT/yR09VaQ7s81R07pBtoS0E9 QrBtoO7aVoEmhlEdRY+fxyh0iXkJaiEB+GllSKh3uap18J9ZkQyMaucRNH+SSxDdrCt3RJ 9V0arfOtyMsM9BoTl85PuHd7i+4m+bao4lQZq2ejP2aRl2fPwMvaknOrNaCAsGk/8u3U7r FIiY1dvQjYhI7bIitiF+o+mSVUVTW7m+Pbi/3pWN2pboctGIwJdMOX1ZUaRpzmTWjIQhyR uS0x5QxgeQ8gMdz/ZsD0/wxYZfTU53lnTpb0lvvV+riwL29uFxSMZI2aP3Bu/w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 820CB78660 for ; Sun, 06 Oct 2024 14:34:56 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxQST-0006jK-OA; Sun, 06 Oct 2024 08:33:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxQSR-0006ik-PO for emacs-orgmode@gnu.org; Sun, 06 Oct 2024 08:33:55 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxQSP-0007en-Cd for emacs-orgmode@gnu.org; Sun, 06 Oct 2024 08:33:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E500C240027 for ; Sun, 6 Oct 2024 14:33:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1728218029; bh=zTFkgAB1A4TJefMSMXSU5sf6LGMk6r6ucrCC+yuWCWk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=DS8R7VFKJn62zJ/FxJITMqmddpcGDiL5Xi+pP0R29672/Hhl7bE5CpmYTeIV9retw 7Xw3Gv7oSUn17Jrc0EKbTC72EMYm2whV/ASNplAqaw4Y0ElTrN/txXa2EHLIZ8bTSe TLG5FDZ2qCnGeLPCMSOHNVDKhiF4QsrcEhcJQpdAoIZuJmhNfwSecYRY6fUTd3deAo xh7qyReea3hB4XbQVkbF+2tVdG6cn3RTj770RJlyBPYHpUdQ6lc26uXSsx9/Mvs7tS fe6/Jfq9KVzAyh8PHYo8dfDRdNT27XURq5Y72I49DG4EjqRDI/iI0NIMu9CnlrmE5u Byg/CZ0oxIzKA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XM1t43tP8z6tyl; Sun, 6 Oct 2024 14:33:48 +0200 (CEST) From: Ihor Radchenko To: lra@phdk.org Cc: Karthik Chikmagalur , Emacs Orgmode Subject: Re: [PATCH] Fixing a regression in org-persists ability to handle non-list container arguments. In-Reply-To: References: <87zfo0qchb.fsf@localhost> <87r09bwary.fsf@gmail.com> <87ikuaqugu.fsf@localhost> Date: Sun, 06 Oct 2024 12:35:37 +0000 Message-ID: <87bjzxtnmu.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.51 X-Spam-Score: -5.51 X-Migadu-Queue-Id: 820CB78660 X-Migadu-Scanner: mx10.migadu.com X-TUID: usOauGg9G9uE lra@phdk.org writes: >> P.S. We really need tests for org-persist. > > Yeah I did note a couple of pretty straight-forward opportunities for > clean-up wrt. redundancies and readability, but without > regression-tests and lacking confidence that I understood everything I > thought it was best to keep the patch as simple as possible. I > would've felt pretty stupid if I accidentally introduced a new > regression in my regression-fix haha. I'll include some of the stuff > from my notes below in case it's of interest to anybody working on > org-persist. > ... It is hard to judge many of the comments without seeing the right context. Ideally, the proposed ideas could be done in a form of patches ;) That said, I would be similarly hesitant to merge large changes in org-persist without adding at least some basic tests. Would you be interested to create testing/lisp/org-persist.el file and add one or two basic tests that replicate what the preview branch does? That way, we can at least make sure that things are not broken as we change the actual library. Then, we can start looking into changing org-persist itself. (Also, having _a_ test file will greatly reduce friction to add more tests) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at