* Quick fix: ATTR_BEAMER not showing in autocompletion
@ 2024-10-05 5:26 Pedro Andres Aranda Gutierrez
2024-10-06 7:48 ` Follow-up on: " Pedro Andres Aranda Gutierrez
2024-10-12 10:54 ` Ihor Radchenko
0 siblings, 2 replies; 6+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2024-10-05 5:26 UTC (permalink / raw)
To: Org Mode List; +Cc: Ihor Radchenko
[-- Attachment #1.1: Type: text/plain, Size: 524 bytes --]
Hi,
I needed to prepare a couple of slides on emacs-30.0.91 and while editing
found that I wasn't getting ATTR_BEAMER in the autocompletion. Attached is
a quick fix for that on the main branch. I hope it can be applied on elpa
too and maybe make it to emacs-30 on time.
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet
[-- Attachment #1.2: Type: text/html, Size: 850 bytes --]
[-- Attachment #2: add-attr-beamer.diff --]
[-- Type: text/x-patch, Size: 607 bytes --]
diff --git a/lisp/org-pcomplete.el b/lisp/org-pcomplete.el
index 01ee2ac8b..7ab3bde5f 100644
--- a/lisp/org-pcomplete.el
+++ b/lisp/org-pcomplete.el
@@ -232,7 +232,8 @@ When completing for #+STARTUP, for example, this function returns
;; a space.
(and (member name '("EXPORT" "SRC")) " "))
block-names)
- (push (format "ATTR_%s: " name) block-names)))
+ (push (format "ATTR_%s: " name) block-names))
+ (push "ATTR_BEAMER:" block-names))
(mapcar (lambda (keyword) (concat keyword ": "))
(org-get-export-keywords))))
(substring pcomplete-stub 2)))
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Follow-up on: Quick fix: ATTR_BEAMER not showing in autocompletion
2024-10-05 5:26 Quick fix: ATTR_BEAMER not showing in autocompletion Pedro Andres Aranda Gutierrez
@ 2024-10-06 7:48 ` Pedro Andres Aranda Gutierrez
2024-11-03 18:04 ` Ihor Radchenko
2024-10-12 10:54 ` Ihor Radchenko
1 sibling, 1 reply; 6+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2024-10-06 7:48 UTC (permalink / raw)
To: Org Mode List; +Cc: Ihor Radchenko
HI again,
After quick fix, a couple of more detailed thoughts:
Use case: I have my lecture notes, slides and laboratory manuals as org files. There are situations where I need to edit in parallel the notes and the slides.
Observation: Variables controlled by #+STARTUP are ‘defcustom’, so they will interfere: for example, the beamer startup option may appear when working on the lecture file or may be suppressed in the presentations depending on how I load the org-files.
Question: why are the variables controlled by #+STARTUP not ‘defvar-local’ ?
This may be a bigger change, so I’d rather discuss it before trying …
Best, /PA
> El 5 oct 2024, a las 7:26, Pedro Andres Aranda Gutierrez <paaguti@gmail.com> escribió:
>
> Hi,
>
> I needed to prepare a couple of slides on emacs-30.0.91 and while editing found that I wasn't getting ATTR_BEAMER in the autocompletion. Attached is a quick fix for that on the main branch. I hope it can be applied on elpa too and maybe make it to emacs-30 on time.
>
> --
> Fragen sind nicht da, um beantwortet zu werden,
> Fragen sind da um gestellt zu werden
> Georg Kreisler
>
> Headaches with a Juju log:
> unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet
>
> <add-attr-beamer.diff>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Quick fix: ATTR_BEAMER not showing in autocompletion
2024-10-05 5:26 Quick fix: ATTR_BEAMER not showing in autocompletion Pedro Andres Aranda Gutierrez
2024-10-06 7:48 ` Follow-up on: " Pedro Andres Aranda Gutierrez
@ 2024-10-12 10:54 ` Ihor Radchenko
1 sibling, 0 replies; 6+ messages in thread
From: Ihor Radchenko @ 2024-10-12 10:54 UTC (permalink / raw)
To: Pedro Andres Aranda Gutierrez; +Cc: Org Mode List
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> I needed to prepare a couple of slides on emacs-30.0.91 and while editing
> found that I wasn't getting ATTR_BEAMER in the autocompletion. Attached is
> a quick fix for that on the main branch. I hope it can be applied on elpa
> too and maybe make it to emacs-30 on time.
Thanks!
I applied a different fix onto bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=96f695034c
Canceled.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Follow-up on: Quick fix: ATTR_BEAMER not showing in autocompletion
2024-10-06 7:48 ` Follow-up on: " Pedro Andres Aranda Gutierrez
@ 2024-11-03 18:04 ` Ihor Radchenko
2024-11-04 6:06 ` Pedro Andres Aranda Gutierrez
0 siblings, 1 reply; 6+ messages in thread
From: Ihor Radchenko @ 2024-11-03 18:04 UTC (permalink / raw)
To: Pedro Andres Aranda Gutierrez; +Cc: Org Mode List
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> Observation: Variables controlled by #+STARTUP are ‘defcustom’, so
> they will interfere: for example, the beamer startup option may appear
> when working on the lecture file or may be suppressed in the
> presentations depending on how I load the org-files.
>
> Question: why are the variables controlled by #+STARTUP not ‘defvar-local’ ?
When options are set via #+STARTUP keyword, they automatically become
buffer-local. See `org-set-regexps-and-options'.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Follow-up on: Quick fix: ATTR_BEAMER not showing in autocompletion
2024-11-03 18:04 ` Ihor Radchenko
@ 2024-11-04 6:06 ` Pedro Andres Aranda Gutierrez
2024-11-04 20:10 ` Ihor Radchenko
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2024-11-04 6:06 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Org Mode List
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Hi,
right, but if they directly were buffer-local from the very beginning, one
wouldn't have to be jumping between files to understand that.
Call it 'pedantic time optimisation' from someone getting older ;-)
best, /PA
On Sun, 3 Nov 2024 at 19:02, Ihor Radchenko <yantar92@posteo.net> wrote:
> Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
>
> > Observation: Variables controlled by #+STARTUP are ‘defcustom’, so
> > they will interfere: for example, the beamer startup option may appear
> > when working on the lecture file or may be suppressed in the
> > presentations depending on how I load the org-files.
> >
> > Question: why are the variables controlled by #+STARTUP not
> ‘defvar-local’ ?
>
> When options are set via #+STARTUP keyword, they automatically become
> buffer-local. See `org-set-regexps-and-options'.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>
--
Fragen sind nicht da, um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
Headaches with a Juju log:
unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run
a leader-deposed hook here, but we can't yet
[-- Attachment #2: Type: text/html, Size: 2298 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Follow-up on: Quick fix: ATTR_BEAMER not showing in autocompletion
2024-11-04 6:06 ` Pedro Andres Aranda Gutierrez
@ 2024-11-04 20:10 ` Ihor Radchenko
0 siblings, 0 replies; 6+ messages in thread
From: Ihor Radchenko @ 2024-11-04 20:10 UTC (permalink / raw)
To: Pedro Andres Aranda Gutierrez; +Cc: Org Mode List
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> right, but if they directly were buffer-local from the very beginning, one
> wouldn't have to be jumping between files to understand that.
> Call it 'pedantic time optimisation' from someone getting older ;-)
Maybe. But there is no clear benefit to change old code for the sake of
purity. While it might break things. We are conservative in Emacs land :)
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-04 20:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 5:26 Quick fix: ATTR_BEAMER not showing in autocompletion Pedro Andres Aranda Gutierrez
2024-10-06 7:48 ` Follow-up on: " Pedro Andres Aranda Gutierrez
2024-11-03 18:04 ` Ihor Radchenko
2024-11-04 6:06 ` Pedro Andres Aranda Gutierrez
2024-11-04 20:10 ` Ihor Radchenko
2024-10-12 10:54 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).