From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bastien.guerry@wikimedia.fr>
Subject: Re: [BUG] org-timer requires org-notify from org-clock
Date: Tue, 07 Sep 2010 02:28:25 +0200
Message-ID: <87aanuz9au.fsf@gnu.org>
References: <87lj7esjwx.fsf@kotik.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=57202 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Osm2z-00025Z-24
	for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 20:28:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <bastienguerry@googlemail.com>) id 1Osm2x-0005ua-N8
	for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 20:28:24 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:65475)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <bastienguerry@googlemail.com>) id 1Osm2x-0005uR-Ge
	for emacs-orgmode@gnu.org; Mon, 06 Sep 2010 20:28:23 -0400
Received: by wyb36 with SMTP id 36so6313463wyb.0
	for <emacs-orgmode@gnu.org>; Mon, 06 Sep 2010 17:28:22 -0700 (PDT)
In-Reply-To: <87lj7esjwx.fsf@kotik.lan> (=?utf-8?Q?=22=C5=81ukasz?=
	Stelmach"'s message of "Mon, 06 Sep 2010 22:21:02 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?utf-8?Q?=C5=81ukasz?= Stelmach <lukasz.stelmach@iem.pw.edu.pl>
Cc: emacs-orgmode@gnu.org

Łukasz Stelmach <lukasz.stelmach@iem.pw.edu.pl> writes:

> It seems like there has to be (require 'org-clock) on top of
> org-timer.el because otherwise the notification lambda
> in-org-timer-set-timer fails because org-notify is not defined and the
> timer starts going forward after it passes 0:00:00. It also looks like
>
> (declare-function org-notify "org-clock" (notification &optional
>                   play-sound))
>
> is not enough. (BTW. now its d-f org-show-notification which is not used
> in org-timer). Simple
>
> (require 'org-clock)
>
> helps, as anything else that loads org-clock like clocking-in.

Fixed, thanks.

-- 
 Bastien