emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bastien.guerry@wikimedia.fr>
To: "Łukasz Stelmach" <lukasz.stelmach@iem.pw.edu.pl>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-timer requires org-notify from org-clock
Date: Tue, 07 Sep 2010 02:28:25 +0200	[thread overview]
Message-ID: <87aanuz9au.fsf@gnu.org> (raw)
In-Reply-To: <87lj7esjwx.fsf@kotik.lan> ("Łukasz Stelmach"'s message of "Mon, 06 Sep 2010 22:21:02 +0200")

Łukasz Stelmach <lukasz.stelmach@iem.pw.edu.pl> writes:

> It seems like there has to be (require 'org-clock) on top of
> org-timer.el because otherwise the notification lambda
> in-org-timer-set-timer fails because org-notify is not defined and the
> timer starts going forward after it passes 0:00:00. It also looks like
>
> (declare-function org-notify "org-clock" (notification &optional
>                   play-sound))
>
> is not enough. (BTW. now its d-f org-show-notification which is not used
> in org-timer). Simple
>
> (require 'org-clock)
>
> helps, as anything else that loads org-clock like clocking-in.

Fixed, thanks.

-- 
 Bastien

      reply	other threads:[~2010-09-07  0:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-06 20:21 [BUG] org-timer requires org-notify from org-clock Łukasz Stelmach
2010-09-07  0:28 ` Bastien [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aanuz9au.fsf@gnu.org \
    --to=bastien.guerry@wikimedia.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=lukasz.stelmach@iem.pw.edu.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).