From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Replaced obsolete interactive-p function Date: Thu, 30 Jun 2011 11:12:37 -0700 Message-ID: <87aacz89yi.fsf@gmail.com> References: <87zkl01u4y.fsf@gnu.org> <877h845l18.wl%markert.michael@googlemail.com> <87vcvojk09.fsf@gmail.com> <87y60jzpfi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:52423) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcLjI-0004IU-VQ for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 14:12:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcLjH-00045C-4E for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 14:12:44 -0400 Received: from mail-iw0-f169.google.com ([209.85.214.169]:49567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcLjG-00044y-MW for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 14:12:42 -0400 Received: by iwn8 with SMTP id 8so2786414iwn.0 for ; Thu, 30 Jun 2011 11:12:42 -0700 (PDT) In-Reply-To: <87y60jzpfi.fsf@gnu.org> (Bastien's message of "Thu, 30 Jun 2011 10:36:17 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Michael Markert , Carsten Dominik Bastien writes: > Hi Eric and Michael, > > Eric Schulte writes: > >> Michael's patch looks great to me, I can confirm that it does stifle the >> warnings on Emacs24, and everything compiles and works as expected -- at >> least as far as the Org-mode test suite is able to differentiate. > > Thanks to Michael for the patch, it does indeed fix the warnings. > >> In addition to applying this patch I've also added another patch which >> supplies the optional KIND argument to every invocation of >> org-called-interactively-p. > > I thought the absence of argument was taken care by the > org-called-interactively-p macro -- see the (with-no-warning ...) > sexp in it, and the comment. > > Eric, any reason for explicitely adding an argument? > > I understand it's better for readability and it will ease the future > replacement of org-called-interactively-p by called-interactively-p, > but I was just curious to know if there was some other reasons. > This extra argument supplies more information to the macro (e.g., an idea of /how/ interactive is considered /interactive/) through taking on the value of 'any or 'interactive. This information is thrown out in older versions of Emacs but is passed on to the called-interactively-p function in Emacs24 and should influence its behavior. Cheers -- Eric > > Thanks! -- Eric Schulte http://cs.unm.edu/~eschulte/