From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Add the capture feature "%(sexp)" to org-feed Date: Fri, 10 Aug 2012 10:53:43 +0200 Message-ID: <87a9y3m8ko.fsf@gnu.org> References: <7822.1339898820@alphaville> <87y5lqe21l.fsf@gnu.org> <87liho86cp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:44398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szky7-0004DW-Op for emacs-orgmode@gnu.org; Fri, 10 Aug 2012 04:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Szky5-0004ds-2B for emacs-orgmode@gnu.org; Fri, 10 Aug 2012 04:53:19 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:36730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Szky4-0004dY-Gh for emacs-orgmode@gnu.org; Fri, 10 Aug 2012 04:53:16 -0400 Received: by wgbez12 with SMTP id ez12so883244wgb.30 for ; Fri, 10 Aug 2012 01:53:15 -0700 (PDT) In-Reply-To: (Michael Brand's message of "Thu, 9 Aug 2012 20:00:37 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Brand Cc: Org Mode --=-=-= Content-Type: text/plain Hi Michael, Michael Brand writes: > Maybe there are still some simplifications? Please try the attached patch and let me know if it works. If you're okay, I'll then apply it under your name. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-the-capture-feature-sexp-to-org-feed.patch >From 757d415af6247ea85f260daaeeb9f143f41e6103 Mon Sep 17 00:00:00 2001 From: Bastien Guerry Date: Fri, 10 Aug 2012 10:52:13 +0200 Subject: [PATCH] Add the capture feature sexp to org feed. * org-feed.el (org-feed-format-entry): Require `org-capture'. Expand Elisp %(...) templates. (org-feed-default-template): Update docstring. * org-capture.el (org-capture-expand-embedded-elisp): New function. (org-capture-fill-template): Use it. (org-capture-inside-embedded-elisp-p): New function to tell if we are within an Elisp %(...) template. --- lisp/org-capture.el | 34 ++++++++++++++++++++++--------- lisp/org-feed.el | 56 ++++++++++++++++++++++++++++++++++----------------- 2 files changed, 62 insertions(+), 28 deletions(-) diff --git a/lisp/org-capture.el b/lisp/org-capture.el index 05e3a0c..7119c2d 100644 --- a/lisp/org-capture.el +++ b/lisp/org-capture.el @@ -1371,15 +1371,7 @@ The template may still contain \"%?\" for cursor positioning." (error (insert (format "%%![Couldn't insert %s: %s]" filename error))))))) ;; %() embedded elisp - (goto-char (point-min)) - (while (re-search-forward "%\\((.+)\\)" nil t) - (unless (org-capture-escaped-%) - (goto-char (match-beginning 0)) - (let ((template-start (point))) - (forward-char 1) - (let ((result (org-eval (read (current-buffer))))) - (delete-region template-start (point)) - (insert result))))) + (org-capture-expand-embedded-elisp) ;; The current time (goto-char (point-min)) @@ -1513,6 +1505,30 @@ The template may still contain \"%?\" for cursor positioning." t) nil)) +(defun org-capture-expand-embedded-elisp () + "Evaluate embedded elisp %(sexp) and replace with the result." + (goto-char (point-min)) + (while (re-search-forward "%(" nil t) + (unless (org-capture-escaped-%) + (goto-char (match-beginning 0)) + (let ((template-start (point))) + (forward-char 1) + (let ((result (org-eval (read (current-buffer))))) + (delete-region template-start (point)) + (insert result)))))) + +(defun org-capture-inside-embedded-elisp-p () + "Return non-nil if point is inside of embedded elisp %(sexp)." + (let (beg end) + (save-excursion + (save-match-data + (when (or (looking-at "%(") + (and (search-backward "%" nil t) (looking-at "%("))) + (setq beg (point)) + (setq end (progn (forward-char) (forward-sexp) (1- (point))))))) + (when (and beg end) + (and (<= (point) end) (>= (point) beg))))) + ;;;###autoload (defun org-capture-import-remember-templates () "Set org-capture-templates to be similar to `org-remember-templates'." diff --git a/lisp/org-feed.el b/lisp/org-feed.el index 6901ffa..8b3414b 100644 --- a/lisp/org-feed.el +++ b/lisp/org-feed.el @@ -225,12 +225,14 @@ Any fields from the feed item can be interpolated into the template with %name, for example %title, %description, %pubDate etc. In addition, the following special escapes are valid as well: -%h the title, or the first line of the description -%t the date as a stamp, either from (if present), or - the current date. -%T date and time -%u,%U like %t,%T, but inactive time stamps -%a A link, from if that is a permalink, else from " +%h The title, or the first line of the description +%t The date as a stamp, either from (if present), or + the current date +%T Date and time +%u,%U Like %t,%T, but inactive time stamps +%a A link, from if that is a permalink, else from +%(sexp) Evaluate elisp `(sexp)' and replace with the result, the simple + %-escapes above can be used as arguments, e.g. %(capitalize \\\"%h\\\")" :group 'org-feed :type '(string :tag "Template")) @@ -506,9 +508,10 @@ This will find DRAWER and extract the alist." ENTRY is a property list. This function adds a `:formatted-for-org' property and returns the full property list. If that property is already present, nothing changes." + (require 'org-capture) (if formatter (funcall formatter entry) - (let (dlines fmt tmp indent time name + (let (dlines time escape name tmp v-h v-t v-T v-u v-U v-a) (setq dlines (org-split-string (or (plist-get entry :description) "???") "\n") @@ -527,20 +530,35 @@ If that property is already present, nothing changes." "")) (with-temp-buffer (insert template) + + ;; Simple %-escapes + ;; before embedded elisp to support simple %-escapes as + ;; arguments for embedded elisp (goto-char (point-min)) (while (re-search-forward "%\\([a-zA-Z]+\\)" nil t) - (setq name (match-string 1)) - (cond - ((member name '("h" "t" "T" "u" "U" "a")) - (replace-match (symbol-value (intern (concat "v-" name))) t t)) - ((setq tmp (plist-get entry (intern (concat ":" name)))) - (save-excursion - (save-match-data - (beginning-of-line 1) - (when (looking-at (concat "^\\([ \t]*\\)%" name "[ \t]*$")) - (setq tmp (org-feed-make-indented-block - tmp (org-get-indentation)))))) - (replace-match tmp t t)))) + (unless (org-capture-escaped-%) + (setq name (match-string 1) + escape (org-capture-inside-embedded-elisp-p)) + (cond + ((member name '("h" "t" "T" "u" "U" "a")) + (setq tmp (symbol-value (intern (concat "v-" name))))) + ((setq tmp (plist-get entry (intern (concat ":" name)))) + (save-excursion + (save-match-data + (beginning-of-line 1) + (when (looking-at + (concat "^\\([ \t]*\\)%" name "[ \t]*$")) + (setq tmp (org-feed-make-indented-block + tmp (org-get-indentation)))))))) + (when tmp + ;; escape string delimiters `"' when inside %() embedded lisp + (when escape + (setq tmp (replace-regexp-in-string "\"" "\\\\\"" tmp))) + (replace-match tmp t t)))) + + ;; %() embedded elisp + (org-capture-expand-embedded-elisp) + (decode-coding-string (buffer-string) (detect-coding-region (point-min) (point-max) t)))))) -- 1.7.10.2 --=-=-= Content-Type: text/plain -- Bastien --=-=-=--