[PATCH] Bug fix: delete indirect buffer's window only when it exists.

[PATCH] Bug fix: delete indirect buffer's window only when it exists.

[Muchenxuan Tong]

Bug fix: delete indirect buffer's window only when it exists.
* org-agenda.el (org-agenda-quit): Delete indirect buffer's window
only when it exists.

When indirect buffer's window doesn't exist, the original logic will
delete the current window.

TINYCHANGE

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index f48ff6f..530e79a 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -6989,7 +6989,9 @@ When `org-agenda-sticky' is non-nil, only bury
the agenda."
   (interactive)
   (if (and (eq org-indirect-buffer-display 'other-window)
    org-last-indirect-buffer)
-      (delete-window (get-buffer-window org-last-indirect-buffer)))
+      (when-let (org-last-indirect-window
+ (get-buffer-window org-last-indirect-buffer))
+ (delete-window org-last-indirect-window)))
   (if org-agenda-columns-active
       (org-columns-quit)
     (if org-agenda-sticky

Re: [PATCH] Bug fix: delete indirect buffer's window only when it exists.

[Achim Gratz]

Muchenxuan Tong writes:
> Bug fix: delete indirect buffer's window only when it exists.
> * org-agenda.el (org-agenda-quit): Delete indirect buffer's window
> only when it exists.

Introduces a new bug: when-let is not defined in GNU Emacs.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for KORG EX-800 and Poly-800MkII V0.9:
http://Synth.Stromeko.net/Downloads.html#KorgSDada

Re: [PATCH] Bug fix: delete indirect buffer's window only when it exists.

[Muchenxuan Tong]

Achim Gratz <Stromeko <at> nexgo.de> writes:

> 
> Muchenxuan Tong writes:
> > Bug fix: delete indirect buffer's window only when it exists.
> > * org-agenda.el (org-agenda-quit): Delete indirect buffer's window
> > only when it exists.
> 
> Introduces a new bug: when-let is not defined in GNU Emacs.
> 
> Regards,
> Achim.

Thanks for pointing out. It's my fault, when-let is defined in slime.el 
and not the Emacs core library.

The following patch should be OK:
----
Bug fix: delete indirect buffer's window only when it exists.
* org-agenda.el (org-agenda-quit): Delete indirect buffer's window
only when it exists.

When indirect buffer's window doesn't exist, the original logic will
delete the current window.

TINYCHANGE

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index f48ff6f..8b9ae81 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -6989,7 +6989,10 @@ When `org-agenda-sticky' is non-nil, only bury
the agenda."
   (interactive)
   (if (and (eq org-indirect-buffer-display 'other-window)
 	   org-last-indirect-buffer)
-      (delete-window (get-buffer-window org-last-indirect-buffer)))
+      (let ((org-last-indirect-window
+	     (get-buffer-window org-last-indirect-buffer)))
+	(if org-last-indirect-window
+	    (delete-window org-last-indirect-window))))
   (if org-agenda-columns-active
       (org-columns-quit)
     (if org-agenda-sticky

Re: [PATCH] Bug fix: delete indirect buffer's window only when it exists.

[Bastien]

Hi Muchenxuan,

Muchenxuan Tong <demon386@gmail.com> writes:

> Thanks for pointing out. It's my fault, when-let is defined in slime.el 
> and not the Emacs core library.
>
> The following patch should be OK:

I've applied the patch.  Please do not insert patches in the body of
the message, attach them.  Also, you can use git format-patch to send
them, it's easier for me to apply.

Thanks,

-- 
 Bastien

Re: [PATCH] Bug fix: delete indirect buffer's window only when it exists.

[Muchenxuan Tong]

Ok. Thanks.

On 22 Jan 2013, at 21:25, Bastien wrote:

> Hi Muchenxuan,
>
> Muchenxuan Tong <demon386@gmail.com> writes:
>
>> Thanks for pointing out. It's my fault, when-let is defined in slime.el
>> and not the Emacs core library.
>>
>> The following patch should be OK:
>
> I've applied the patch.  Please do not insert patches in the body of
> the message, attach them.  Also, you can use git format-patch to send
> them, it's easier for me to apply.
>
> Thanks,
>
> --
> Bastien