Re: bug in expansion of variables in babel Perl

[Eric Schulte <schulte.eric@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3452 bytes --]

Achim Gratz <Stromeko@nexgo.de> writes:

> D M German writes:
>> I see two ways to solve this. The first is simply to replace the output
>> format of the variable from "%S" to "'%s'" (use quotes ').
>
> I think that's the right thing to do.  There shouldn't be anything in
> the table that needs to be interpolated by Perl while the variable is
> defined.
>
>> +    (format "'%s'" var)))
>
> A slightly more perlish way would be to use
>        (format "q(%s)" var)))
>

I just added the variable `org-babel-perl-var-wrap', into ob-perl.el

    ;; emacs-lisp
    (defvar org-babel-perl-var-wrap "q(%s)"
      "Wrapper for variables inserted into Perl code.")

This way we will get what sounds like improved wrapping by default, but
users who really do want to insert interpolated values can customize
this variable.

>
>> Debugging perl is very cumbersome in org-mode. It would be nice to have
>> a feature to export the source to a file. This is because the variable
>> expansion needs to be done before the code can be used (hence simply cut
>> and paste does not work, nor shell-command-on-region)
>
> The other languages have the same problem, maybe there should be a
> general option to mirror the commands into a source block in the org
> file or to make the buffer with the program to be eval'ed stick around.
>
> Eric, WDYT?

Are you familiar with `org-babel-expand-src-block' bound to C-c C-v v?
If I understand the desire correctly, it should be what you're after.
Perhaps an option to raise the expanded source code buffer along with
the error buffer when an error is raised would be a useful addition.

> Also, I'm not really sure why we need all the complexity of
> shell-command-on-region when it looks like we should be able to
> call-process-region ourselves.  Modifying Babel to run (non-session
> and perhaps optionally) from files instead of buffers seems to be a
> more wide-reaching operation.
>

This complexity is related to the need to occasionally run in remote
directories or on remote machines.  If there are ways to reduce this
complexity without losing functionality I'm game.

>
>> As we are into it, I found this declaration to be very useful. 
> […]
>
> I think this is better done by altering org-babel-perl-command to
> include "-Mstrict".  If you put the helper functions into a module in
> @INC or tell Perl where to find them, then you can add "-Mmyhelper" as
> well.  Here's a wrapper to match:
>
> (defvar org-babel-perl-wrapper-method
>   "{
>   my @r = eval( q(%s) );
>   open my $BO, qq(>%s));
>   print $BO join($\\, @r), $\\ ;
> }")
>
> For your problem with :results output blocks, I think it would be
> possible to wrap them (a bit differently) also, but the "helper module"
> above would also solve this problem, so let's see what Eric says since I
> don't know if another language has already set a precedent of wrapping
> these commands too.
>

I'm not currently aware of any language-wide support for printing the
expanded code block along with the results.  I don't think there has
been any desire for this previously.  It shouldn't be hard to write an
emacs lisp block to give the desired result...

Here's an example of such a function.  Please forgive my complete lack
of Perl knowledge (at one time I knew it well). Note that I had to make
a small change to the return value of `org-babel-expand-src-block'.


[-- Attachment #2: it.org --]
[-- Type: text/x-org, Size: 603 bytes --]

#+name: table
| 1 | 2 | 3 |
| 4 | 5 | 6 |

#+name: perl-block
#+begin_src perl :var table=table
  print $table
#+end_src

#+RESULTS: perl-block
: 1

#+begin_src emacs-lisp :var block="perl-block" :results raw
  (save-excursion
    (message "block is %S" block)
    (org-babel-goto-named-src-block block)
    (format "#+begin_example\n%S\n↓\n%s\n#+end_example\n"
            (org-babel-expand-src-block)
            (org-babel-execute-src-block)))
#+end_src

#+RESULTS:
#+begin_example
"$table=[[q(1), q(2), q(3)], [q(4), q(5), q(6)]];
print $table"
↓
1

#+end_example


[-- Attachment #3: Type: text/plain, Size: 254 bytes --]


>
>>
>> Finally, if interested, i can write a couple of examples for Perl that
>> could help people who want to use it. 
>
> Also a few tests would be highly welcome.
>

+1

Cheers,

>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte