From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [PATCH] replace function name in org-bbdb Date: Sat, 30 Mar 2013 16:51:42 +0100 Message-ID: <87a9pkvqb5.fsf@pank.eu> References: <87k3opuiw8.fsf@pank.eu> <87boa1ymj3.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULy4N-0004Dg-Lb for emacs-orgmode@gnu.org; Sat, 30 Mar 2013 11:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULy4H-0005yM-PK for emacs-orgmode@gnu.org; Sat, 30 Mar 2013 11:51:51 -0400 Received: from mout.gmx.net ([212.227.17.22]:55894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULy4H-0005xt-G5 for emacs-orgmode@gnu.org; Sat, 30 Mar 2013 11:51:45 -0400 Received: from mailout-eu.gmx.com ([10.1.101.210]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Lj83k-1Uvqa11EQI-00dDSh for ; Sat, 30 Mar 2013 16:51:43 +0100 In-Reply-To: <87boa1ymj3.fsf@bzg.ath.cx> (Bastien's message of "Sat, 30 Mar 2013 15:45:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: bzg@altern.org Cc: emacs-orgmode@gnu.org Bastien, >> org-bbdb-anniversary was not working on my system before using bbdb3 >> from package.el (probably from MELPA...). This fixes this by renaming >> a function which has been changed upstream. > > Looks good. Is there any versioning we can check in order to know > what function's name will the users use? bbdb3 hasn't been released yet. It's a moving target and I would assume that people who use it are on the edge of the development. . . The function(s) in question were renamed four months ago. In any case this function will check that one has a sufficiently new version of of bbdb (based on the change log I linked to in the commit message). Should I make a local version of the bbdb field lookup function and let the value be determined by the test below? I unfortunately don't know what the version was called around 2012/12/25 so I test using the date, which may or may not be too fragile. #+BEGIN_SRC emacs-lisp (when (fboundp 'bbdb-version) (string-match "\\([0-9]\\{4\\}/[0-9]\\{2\\}/[0-9]\\{2\\}\\)" (bbdb-version)) (version<= (replace-regexp-in-string "/" "." (match-string 1 (bbdb-version))) "2012.12.25")) #+END_SRC Thanks, Rasmus -- May the Force be with you