From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] ox-icalendar: fix handling of timestamps Date: Sun, 11 Aug 2013 15:15:46 +0200 Message-ID: <87a9koz7ul.fsf@gmail.com> References: <20130811020358.GA30350@kenny.local> <87mwooznuk.fsf@gmail.com> <20130811124214.GA69042@kenny.local> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8VUi-0004At-9B for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 09:15:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8VUc-0003WF-83 for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 09:15:40 -0400 Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:54938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8VUc-0003WA-1k for emacs-orgmode@gnu.org; Sun, 11 Aug 2013 09:15:34 -0400 Received: by mail-we0-f182.google.com with SMTP id u55so4671435wes.41 for ; Sun, 11 Aug 2013 06:15:33 -0700 (PDT) Received: from selenimh (ala65-1-82-246-127-176.fbx.proxad.net. [82.246.127.176]) by mx.google.com with ESMTPSA id bt8sm11243252wib.8.2013.08.11.06.15.32 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 11 Aug 2013 06:15:32 -0700 (PDT) In-Reply-To: <20130811124214.GA69042@kenny.local> (Viktor Rosenfeld's message of "Sun, 11 Aug 2013 14:42:14 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Viktor Rosenfeld writes: > The docstring of `org-icalendar-with-timestamps' already states: > > This variable has precedence over `org-export-with-timestamps'. > It can also be set with the #+OPTIONS line, e.g. "<:t". This wouldn't be sufficient: "has precedence over" isn't a synonym for "change the meaning of". > I believe that inconsistency is desirable here. Consider the following > use case with three headlines: > > * TODO An appointment in the future > <2013-08-12 So 09:00> > * DONE A note about an appointment in the past > [2013-08-10 Fr 09:00] > * WAIT A reminder how long I've been waiting for something [2013-08-10 Fr] > > The previous behavior, with `org-icalendar-with-timestamps' set to > 'active, was that the first and the last headlines were picked up (even > though the timestamp in the last headline is inactive). This was > unexpected because the two inactive timestamps are handled > differently. This is to be expected according to `org-export-with-timestamps'. > My expectation was that only the first headline should have been > exported. This is what my patch achieves. The meaning of `org-export-with-timestamps' is the result of a discussion in this ML. Please read the whole thread starting at: http://permalink.gmane.org/gmane.emacs.orgmode/69971 Regards, -- Nicolas Goaziou