emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: coroa@online.de (Jonas Hörsch)
To: emacs-orgmode@gnu.org
Subject: [PATCH] Re: [BUG] org-cycle on hidden inline task makes also other inline tasks visible
Date: Tue, 29 Oct 2013 17:46:02 +0100	[thread overview]
Message-ID: <87a9hsc9f9.fsf@kafka.loc> (raw)
In-Reply-To: 87ioyftsdn.fsf@kafka.loc


[-- Attachment #1.1: Type: text/plain, Size: 178 bytes --]

hi,

ok, this has been bothering me long enough. the attached patch fixes the
issue [1] for me.

cheers,
jonas

Footnotes:

[1] http://thread.gmane.org/gmane.emacs.orgmode/76034

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-org-inlinetask-FIX-correct-inlinetask-cycling.patch --]
[-- Type: text/x-patch, Size: 1170 bytes --]

From 3073cb181f607a0cc65031fe68e86cf73347e152 Mon Sep 17 00:00:00 2001
From: Jonas Hoersch <coroa@online.de>
Date: Tue, 29 Oct 2013 17:07:49 +0100
Subject: [PATCH] org-inlinetask: [FIX] correct inlinetask cycling

org-show-entry can't be used to expand a folded inlinetask, as it relies
on org-outline-regexp to find the end of the entry, which has been
altered to exclude inline-tasks by org-cycle.

instead show the inline task directly using the bounds already computed
by org-inlinetask-toggle-visibility.
---
 lisp/org-inlinetask.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org-inlinetask.el b/lisp/org-inlinetask.el
index 112d3df..ca7572b 100644
--- a/lisp/org-inlinetask.el
+++ b/lisp/org-inlinetask.el
@@ -315,7 +315,8 @@ If the task has an end part, also demote it."
      ((= end start))
      ;; Inlinetask was folded: expand it.
      ((get-char-property (1+ start) 'invisible)
-      (org-show-entry))
+      (outline-flag-region start end nil)
+      (org-cycle-hide-drawers 'children))
      (t (outline-flag-region start end t)))))
 
 (defun org-inlinetask-remove-END-maybe ()
-- 
1.8.4


[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

  parent reply	other threads:[~2013-10-29 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 11:33 [BUG] org-cycle on hidden inline task makes also other inline tasks visible Jonas Hörsch
2013-09-06  1:23 ` John Hendy
2013-10-29 16:46 ` Jonas Hörsch [this message]
2013-10-29 20:02   ` [PATCH] " Nicolas Goaziou
2013-10-29 22:38     ` Jonas Hörsch
2013-10-29 23:36       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9hsc9f9.fsf@kafka.loc \
    --to=coroa@online.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).