From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [RFC] Properly handle keyword + COMMENT keyword
Date: Fri, 11 Apr 2014 10:59:11 +0200
Message-ID: <87a9bs57cg.fsf@bzg.ath.cx>
References: <87txanjn0i.fsf@gmail.com> <87sipkkiro.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45566)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WYbPk-0004wV-K2
	for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 09:22:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WYbPX-0007s2-CP
	for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 09:22:40 -0400
Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:46874)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WYbPX-0007rb-0a
	for emacs-orgmode@gnu.org; Fri, 11 Apr 2014 09:22:27 -0400
Received: by mail-wg0-f50.google.com with SMTP id x13so5487398wgg.9
	for <emacs-orgmode@gnu.org>; Fri, 11 Apr 2014 06:22:25 -0700 (PDT)
In-Reply-To: <87sipkkiro.fsf@gmail.com> (Nicolas Goaziou's message of "Thu, 10
	Apr 2014 22:54:19 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>

Hi Nicolas,

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>> Thus, this patch
>>
>>  - properly fontifies headlines with both a regular keyword and
>>    a COMMENT keyword,
>>
>>  - fixes `org-toggle-comment' and `org-todo' to handle both COMMENT
>>    keyword and another one
>>
>>  - adds some consistency to functions implementing their own COMMENT
>>    matching (e.g., with or without case-sensitivity).
>
> Applied.

Thanks -- this is a welcome improvement.

Speaking of consistency, I noticed this minor glitch:

* NEXT COMMENT A headline [0/2]

- [ ] A
- [ ] B

* NEXT [#A] [1/2] COMMENT Another headline

- [X] A
- [ ] B

See that the second COMMENT is not fontified and I think
it will not be processed correctly.

Now that COMMENT will not be always the first word of a
headline, we should mention that TODO keywords and priority
cookies are allowed before a COMMENT keyword, while stats
cookies are not.  (Or allow stats cookies for simplicity's
sake.)

What do you think?

-- 
 Bastien