From: Eric Schulte <schulte.eric@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 17416@debbugs.gnu.org, Eric Schulte <schulte.eric@gmail.com>
Subject: bug#17416: bug#17416: insecure temp files in ob-screen.el
Date: Thu, 08 May 2014 12:20:23 -0600 [thread overview]
Message-ID: <87a9asku8o.fsf__43604.6604453169$1399573313$gmane$org@gmail.com> (raw)
In-Reply-To: <dda9asvjj2.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 08 May 2014 03:04:01 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Eric Schulte wrote:
>
>>> org-babel-screen-session-write-temp-file and org-babel-screen-test seem
>>> to use predictable temp-file names, which is a security issue. Using
>>> `make-temp-file', or if the file names really need to be predictable,
>>> something equivalent to `doc-view-make-safe-dir' (there should really be
>>> a general utility function for this IMO) to first create a /tmp
>>> subdirectory would avoid this.
>>
>> I just pushed up a fix for this issue. Thanks,
>
> If you mean
>
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=fea672d30ef4701721c0d4aa70462760a6b21be7
>
> then's there still org-babel-screen-test.
>
Fixed.
>
> (These are definitely fixes that need merging into the emacs-24 branch.
> IIUC this means they need to be in your maint branch?)
Cherrypicked into maint.
Thanks,
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
prev parent reply other threads:[~2014-05-08 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <61ljbl1v.fsf@fencepost.gnu.org>
2014-05-07 9:35 ` bug#17416: bug#17416: insecure temp files in ob-screen.el Eric Schulte
2014-05-08 7:04 ` Glenn Morris
[not found] ` <dda9asvjj2.fsf@fencepost.gnu.org>
2014-05-08 18:20 ` Eric Schulte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87a9asku8o.fsf__43604.6604453169$1399573313$gmane$org@gmail.com' \
--to=schulte.eric@gmail.com \
--cc=17416@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).