emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [DEV] Text quoting backports
@ 2015-09-06  6:12 Kyle Meyer
  2015-09-06 13:24 ` Rasmus
  2015-09-07 19:18 ` Nicolas Goaziou
  0 siblings, 2 replies; 4+ messages in thread
From: Kyle Meyer @ 2015-09-06  6:12 UTC (permalink / raw)
  To: Org-mode

Hello,

There have been several commits made recently in the Emacs repo related
to quoting style in docstrings and messages.  I've backported the
changes touching Org files and pushed to the branch maint-quotes.  I put
them there instead of installing them directly on maint to allow time
for things in the Emacs repo to settle and to get feedback about how I
plan to incorporate these changes.  (Judging from the discussion on
emacs.devel [1-5], there may be various opinions on this.)

Regardless of how we decide to use these changes, I'd prefer to include
all the commits and then follow up with additional commits necessary to
get to the desired state.  This way there is a clear record of each
commit being considered.

Below is my plan at the moment, organized by different types of changes.
Thoughts?

------------------------------------------------------------------------

* s/'symbol/`symbol'/

  Keep changes.

* s/'.*'/‘.*’/ and s/`.*'/‘.*’/

  Revert changes. Regardless of whether these substitutions are made,
  these will be handled by message and friends to display according to
  text-quoting-style, so the displayed result in the help buffer will be
  the same.

* s/\".*\" /“.*”/

  Revert changes.

* s/'/\\='/

  Keep changes.

* s/'(.*)/(.*)/

  Some of the changes removed single quotes.  For example,

  -    '((\"c\" \"d\" ((in-mode . \"message-mode\"))))
  +   ((\"c\" \"d\" ((in-mode . \"message-mode\"))))

  Others protected the single quote. For example,

  -    '((\"p\" \"q\" ((in-file . \"\\\\.txt\\\\'\"))))
  +    \\='((\"p\" \"q\" ((in-file . \"\\\\.txt\\\\'\"))))

  I've been unable to figure out the logic here as to when a quote form
  like this was removed versus protected.  I plan to convert all cases
  that were removed to \\=' instead.

* s/format/format-message/ calls

  Keep changes.

* Added substitute-command-keys calls

  Keep changes, but extend to use command names instead of hard coding
  keys.

------------------------------------------------------------------------

[1] http://thread.gmane.org/gmane.emacs.devel/189240
[2] http://thread.gmane.org/gmane.emacs.devel/188822
[3] http://thread.gmane.org/gmane.emacs.devel/189331
[4] http://thread.gmane.org/gmane.emacs.devel/189621
[5] And maybe other threads I'm missing

--
Kyle

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-09-07 19:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-06  6:12 [DEV] Text quoting backports Kyle Meyer
2015-09-06 13:24 ` Rasmus
2015-09-06 14:43   ` Kyle Meyer
2015-09-07 19:18 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).