From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] ob-sql.el: Support sqlcmd and cygwin environment Date: Sat, 11 Jun 2016 10:40:55 +0200 Message-ID: <87a8isdso8.fsf@saiph.selenimh> References: <87r3c4em1r.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBeTc-0004lB-GY for Emacs-orgmode@gnu.org; Sat, 11 Jun 2016 04:41:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBeTY-0002oP-DN for Emacs-orgmode@gnu.org; Sat, 11 Jun 2016 04:41:07 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBeTY-0002oJ-6A for Emacs-orgmode@gnu.org; Sat, 11 Jun 2016 04:41:04 -0400 Received: from saiph.selenimh (unknown [IPv6:2a03:a0a0:0:4301::b3c]) (Authenticated sender: mail@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id A614D1720A9 for ; Sat, 11 Jun 2016 10:41:01 +0200 (CEST) In-Reply-To: (Xi Shen's message of "Sat, 11 Jun 2016 02:17:52 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" Cc: "Emacs-orgmode@gnu.org" Hello, Xi Shen writes: > According to > https://www.gnu.org/software/emacs/manual/html_node/elisp/Standard-File-Names.html, > the `convert-standard-filename` works for *nix and MS-DOS, but not Cygwin > environment. And I tested, it does not work. For the prefix, please advice > me a better one. Maybe we should path this function first? How can I > patch/update a Emacs native function? Since there is no module in Emacs, you need to prefix functions and variables according to the package, or, even better, the library they belong to. Hence, functions and variables in "ob-sql.el" are prefixed with "org-babel-sql-". Do you mind discussing it upstream on emacs-devel ML first? I don't think this kind of function belongs to Org. If upstream has no equivalent and doesn't want to add one, we might consider adding it to the library. WDYT? >> > The `osql` command line tool was last updated in 2004, >> > https://technet.microsoft.com/en-us/library/aa214012(v=sql.80).aspx, >> > and could not output the query result in a way that morden >> > `org-table.el` expects. The `sqlcmd` is the preferred command line >> > tool to connect the Microsoft SQL Server and it also has a Linux >> > version, >> > https://msdn.microsoft.com/en-us/library/hh568447(v=sql.110).aspx. >> >> Would it make sense to remove the msosql support then? >> > Yes, but I am also thinking about backward compatibility. Do you want > me to create a patch to remove `msosql` support? AFAIU, according to your comment, "osql" output is barely usable. If you think it is still usable and even used by some users, then I do not mind keeping it. I just wanted to be sure we're not keeping something that is not reasonable to keep. >> #'identity >> >> >>> OK, but what's the difference? Care to give me a short lesson? >>>Thanks! Not much difference, hence the "nitpick" tag. 'identity is a generic symbol, #'identity clearly indicates we (the user, the compiler) are interested in the symbol function cell. In this case, it is obvious, but it is not always the case in other parts of the code base, and more consistency in the right direction doesn't hurt. Regards, -- Nicolas Goaziou