From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: colored-links take 2
Date: Fri, 01 Jul 2016 14:58:38 +0200
Message-ID: <87a8i1ikg1.fsf@saiph.selenimh>
References: <m260sqmugw.fsf@Johns-MacBook-Air.local>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bIy1z-00049n-Oz
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2016 08:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bIy1t-0003KF-TP
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2016 08:58:50 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bIy1t-0003IM-MQ
	for emacs-orgmode@gnu.org; Fri, 01 Jul 2016 08:58:45 -0400
In-Reply-To: <m260sqmugw.fsf@Johns-MacBook-Air.local> (John Kitchin's message
	of "Thu, 30 Jun 2016 13:56:15 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

John Kitchin <jkitchin@andrew.cmu.edu> writes:

> I forgot a little piece in the last patch. This one is probably right.

Thank you. Some comments follow.

> +(defcustom org-link-display-parameters nil 
> +  "An alist of properties to display a link with.

An alist between link types and properties to ...

> +The first element in each list is a string of the link

first element -> key

> +type. Subsequent optional elements make up a p-list. :face can be

Double spaces are required between sentences.

> +used to change the face on the link (the default is
> +`org-link'. If :display is 'full the full link will show in

Ditto. Also 'full -> `full'.

There should probably be other allowed values for :display, e.g., `path'
and `description'.

> +descriptive link mode."
> +  :type '(alist :tag "Link display paramters"
> +		:key-type 'string
> +		:value-type '(plist))
> +  :group 'org-link)

:type is wrong, it should be string' not 'string and plist instead of
'(plist). Also, allowed keywords should probably be specified somewhere.

>  			     (list 'mouse-face 'highlight
> -				   'face 'org-link
> +				   'face (or (plist-get
> +					      (cdr (assoc type org-link-display-parameters))
> +					      :face)
> +					     'org-link)

(plist-get ....) is begging for a getter, e.g.
`org-link--parameter-value' (which is called with two arguments, the
type as a string and the property as a keyword).

> +	   (ip (list 'invisible (or (plist-get
> +				     (cdr (assoc type org-link-display-parameters))
> +				     :display)
> +				    'org-link)

See above.

Regards,