> The changes look fine. Could you send them using git format-patch, with > a proper commit message? See > for details. The attached patch (using git format-patch) is adding test-ob-lua.el and ob-lua.el. My contribution to ob-lua.el is only a tiny patch on top of Dieter's ob-lua.el but it appears as a new file in the patch, since ob-lua.el is not currently in the repository. >> By the way, when trying to run the tests from emacs, I had an error >> message when doing a (require 'org-test): "let: Required feature `ert-x' >> was not provided". Am I doing something wrong? I worked around it by >> (1) installing the `ertx' package and (2) replacing (require 'ert-x) by >> (require 'ertx) in org-test.el (that's probably the wrong thing to do, >> but it allowed me to run my tests). > > I usually only call "make test" from Org root directory. I am still a bit confused about this (make test complains about a missing dependency for ob-lua, maybe because it is in contrib/lisp?), but I can run the test using the command line emacs --batch command described in testing/README, and it does not require any change to org-test.el, so I'll run tests this way from now on. > Also, I suggest to move `should' and the test on the outside of the > sexp, like this Done, thanks. Please let me know if some other changes are needed. Thanks for the guidance. thibault