From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: Status line change? Date: Thu, 22 Jun 2017 21:36:13 -0400 Message-ID: <87a84z7aeq.fsf@kyleam.com> References: <20170622233907.GA16800@volibear.adamsinfoserv.com> <87h8z77dky.fsf@kyleam.com> <20170623005342.GC16800@volibear.adamsinfoserv.com> <87d19v7bb9.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dODWG-0001yx-2K for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:36:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dODWC-0004mF-Vy for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:36:20 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:56784 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dODWC-0004ls-Na for emacs-orgmode@gnu.org; Thu, 22 Jun 2017 21:36:16 -0400 In-Reply-To: <87d19v7bb9.fsf@kyleam.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Russell Adams , emacs-orgmode Kyle Meyer writes: > That change seems to have unintentionally reversed the visibility check, > which should be > > -- >8 -- > diff --git a/lisp/org.el b/lisp/org.el > index 1e6d00973..d9b6489ff 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -12681,7 +12681,7 @@ (defun org-todo (&optional arg) > (replace-match next t t) > (cond ((equal this org-state) > (message "TODO state was already %s" (org-trim next))) > - ((pos-visible-in-window-p hl-pos) > + ((not (pos-visible-in-window-p hl-pos)) > (message "TODO state changed to %s" (org-trim next)))) > (unless head > (setq head (org-get-todo-sequence-head org-state) Pushed (1930a8f05ac3c09b6366491c076a3efde2f2205d). -- Kyle