From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: Quit and Error in org-export--dispatch-action
Date: Thu, 05 Dec 2019 05:27:06 -0500
Message-ID: <87a787gj9h.fsf@kyleam.com>
References: <CAJsv8TFgMbjRGEb1D+bZkg9W0CWUR5KtFh7zdUdGm6FFrxPouA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:56634)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <kyle@kyleam.com>) id 1icoLp-0004yB-KD
 for emacs-orgmode@gnu.org; Thu, 05 Dec 2019 05:27:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <kyle@kyleam.com>) id 1icoLn-0006Hc-NA
 for emacs-orgmode@gnu.org; Thu, 05 Dec 2019 05:27:12 -0500
Received: from pb-smtp1.pobox.com ([64.147.108.70]:58342)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1icoLn-0006B3-9v
 for emacs-orgmode@gnu.org; Thu, 05 Dec 2019 05:27:11 -0500
In-Reply-To: <CAJsv8TFgMbjRGEb1D+bZkg9W0CWUR5KtFh7zdUdGm6FFrxPouA@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
 <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Takaaki Ishikawa <takaxp@ieee.org>, orgmode list <emacs-orgmode@gnu.org>

Hi Takaaki,

Takaaki Ishikawa <takaxp@ieee.org> writes:

> The org-export provides a quitting option for user by typing `q`.
> This is nice feature but it is implemented with an error function.
> For me, it is not actually an error, it is one of the user actions,
> and when `debug-on-error` is `t`, the Backtrace buffer will be
> popped up every time. It is annoying.

True, that shouldn't be treated as a plain error.

> Please find a patch to replace error function with a simple message.
> What do you think?
>
>[...]
>
> --- a/lisp/ox.el
> +++ b/lisp/ox.el
> @@ -6929,8 +6929,8 @@ options as CDR."
>        (org-export--dispatch-ui options first-key expertp))
>       ;; q key at first level aborts export.  At second level, cancel
>       ;; first key instead.
> -     ((eq key ?q) (if (not first-key) (error "Export aborted")
> -		    (org-export--dispatch-ui options nil expertp)))
> +     ((eq key ?q) (if first-key (org-export--dispatch-ui options nil expertp)
> +		    (message "Export aborted") '(ignore)))

Hmm, what about instead replacing the call to `error' with a call to
`user-error'?  If that works for you, could you send an updated patch
with a commit message?  (Org's commit message conventions are described
at <https://orgmode.org/worg/org-contribute.html#commit-messages>.)