From: Kyle Meyer <kyle@kyleam.com>
To: Takaaki Ishikawa <takaxp@ieee.org>, orgmode list <emacs-orgmode@gnu.org>
Subject: Re: Quit and Error in org-export--dispatch-action
Date: Thu, 05 Dec 2019 05:27:06 -0500 [thread overview]
Message-ID: <87a787gj9h.fsf@kyleam.com> (raw)
In-Reply-To: <CAJsv8TFgMbjRGEb1D+bZkg9W0CWUR5KtFh7zdUdGm6FFrxPouA@mail.gmail.com>
Hi Takaaki,
Takaaki Ishikawa <takaxp@ieee.org> writes:
> The org-export provides a quitting option for user by typing `q`.
> This is nice feature but it is implemented with an error function.
> For me, it is not actually an error, it is one of the user actions,
> and when `debug-on-error` is `t`, the Backtrace buffer will be
> popped up every time. It is annoying.
True, that shouldn't be treated as a plain error.
> Please find a patch to replace error function with a simple message.
> What do you think?
>
>[...]
>
> --- a/lisp/ox.el
> +++ b/lisp/ox.el
> @@ -6929,8 +6929,8 @@ options as CDR."
> (org-export--dispatch-ui options first-key expertp))
> ;; q key at first level aborts export. At second level, cancel
> ;; first key instead.
> - ((eq key ?q) (if (not first-key) (error "Export aborted")
> - (org-export--dispatch-ui options nil expertp)))
> + ((eq key ?q) (if first-key (org-export--dispatch-ui options nil expertp)
> + (message "Export aborted") '(ignore)))
Hmm, what about instead replacing the call to `error' with a call to
`user-error'? If that works for you, could you send an updated patch
with a commit message? (Org's commit message conventions are described
at <https://orgmode.org/worg/org-contribute.html#commit-messages>.)
next prev parent reply other threads:[~2019-12-05 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 7:42 Quit and Error in org-export--dispatch-action Takaaki Ishikawa
2019-12-05 10:27 ` Kyle Meyer [this message]
2019-12-05 13:59 ` Takaaki Ishikawa
2019-12-06 3:48 ` Kyle Meyer
2019-12-09 4:58 ` Takaaki Ishikawa
2019-12-09 10:39 ` Kyle Meyer
2019-12-09 15:02 ` Takaaki Ishikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a787gj9h.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=takaxp@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).